Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish minutes of 2022-02-17 meeting #166

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Publish minutes of 2022-02-17 meeting #166

merged 1 commit into from
Mar 2, 2022

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Feb 17, 2022

Generated from https://docs.google.com/document/d/1QkwhEMtMS67JBUkl_WVPZ4lRSKoWcQNlLJSf_GwSXg8/edit using the tool and process from #105.

During this meeting we discussed or mentioned #159, #160, #163, #99, #98, #96, #95, #97, #120, #154.

Copy link

@ghostwords ghostwords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something went wrong and the notes are missing.

@Rob--W
Copy link
Member Author

Rob--W commented Feb 19, 2022

Looks like something went wrong and the notes are missing.

Thanks. I had forgotten to check in the file.

Copy link
Member

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a very minor and a medium sized clarification. Once those are merged into the PR I think the we're good to merge it into main.

_minutes/2022-02-17-wecg.md Outdated Show resolved Hide resolved
* [jack] if arbitrary code is not allowed in MV3, how can Tampermonkey run user scripts?
* [simeon] The scripting API will be expanded to support user scripts. (post meeting edit: we to gate access to this capability similar to Chrome's current "allow access to file URLs" control)
* [tomislav] Two features are being mixed up in this discussion: 1) running scripts in the main world synchronously and 2) running arbitrary scripts (not shipped with extension) in the main world from a content script.
* [simeon] The world property of the scripting API allows the selection of the world. We believe that this allows extensions to schedule scripts in the desired order.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [simeon] The world property of the scripting API allows the selection of the world. We believe that this allows extensions to schedule scripts in the desired order.
* [simeon] The world property of the scripting API allows the selection of the world. We believe that this allows extensions to schedule scripts in the desired order.
* [simeon] Let's try a different framing. In order to inject a content script into the main world, an extension developers would declare a content script object in manifest.json, but add a new "world" property. This prop takes a value of either MAIN or ISOLATED. The scripting API's dynamic content script support will also be expanded to support this property.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this line to the notes, but I note that this comment is part of a larger conversation during the meeting where I and other participants tried to emphasize that there are use cases where extensions want to decide at runtime where main world scripts are injected by the content script. The "func" feature of scripting.executeScript is to allow extensions to run logic without being forced to run create separate files for every bit of logic.

Neither dynamic nor static (manifest) content scripts would allow extensions to synchronously run main world scripts from the content script.

@Rob--W
Copy link
Member Author

Rob--W commented Mar 2, 2022

Merging again because the next meeting will happen tomorrow. Let's try to get this merged sooner next time.

@Rob--W Rob--W merged commit 880620a into main Mar 2, 2022
github-actions bot added a commit that referenced this pull request Mar 2, 2022
SHA: 880620a
Reason: push, by @Rob--W

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants