Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: manifest key trial_tokens #598

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Proposal: manifest key trial_tokens #598

wants to merge 4 commits into from

Conversation

bershanskiy
Copy link
Member

This proposal formalizes #454 into a concise document.

@bershanskiy bershanskiy self-assigned this Apr 18, 2024
patrickkettner
patrickkettner reviewed Apr 18, 2024
View reviewed changes
proposals/manifest_trial_tokens.md Outdated Show resolved Hide resolved
proposals/manifest_trial_tokens.md Outdated Show resolved Hide resolved
patrickkettner
patrickkettner approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@patrickkettner patrickkettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one nit. I think it would make sense to link to some kind of document about what origin trials are. either on mdn or a chromium explainer or something.

@bershanskiy bershanskiy requested a review from zombie April 20, 2024 12:09
@bershanskiy bershanskiy mentioned this pull request Apr 23, 2024
Closed
@Rob--W Rob--W mentioned this pull request Apr 25, 2024
Merged
@bershanskiy bershanskiy requested review from Rob--W and removed request for zombie May 3, 2024 17:39
dotproto
dotproto approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial version of this proposal looks solid to me. I'm in favor of merging and iterating on the design as necessary in subsequent PRs as vendors explore implementations.

proposals/manifest_trial_tokens.md Outdated Show resolved Hide resolved
proposals/manifest_trial_tokens.md Outdated Show resolved Hide resolved
@bershanskiy bershanskiy force-pushed the proposals-manifest-trial_tokens branch from 199cf49 to 9f3ce3a Compare May 9, 2024 18:08
@bershanskiy bershanskiy force-pushed the proposals-manifest-trial_tokens branch from 9f3ce3a to 6a7b460 Compare May 12, 2024 07:02
@dotproto dotproto mentioned this pull request Jun 6, 2024
Closed
@Rob--W Rob--W requested review from zombie and removed request for Rob--W June 6, 2024 15:44
@Rob--W Rob--W mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukul-p mukul-p mukul-p approved these changes

@dotproto dotproto dotproto approved these changes

@patrickkettner patrickkettner patrickkettner approved these changes

@xeenon xeenon xeenon approved these changes

@zombie zombie Awaiting requested review from zombie

Assignees

@bershanskiy bershanskiy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bershanskiy @xeenon @patrickkettner @dotproto @mukul-p