Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the name and short_name prose. #61

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Conversation

xeenon
Copy link
Collaborator

@xeenon xeenon commented Aug 20, 2021

Fixes issue #60.

Copy link
Contributor

@ariasuni ariasuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions which I feel improves slightly your initial wording.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link
Member

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the PR in its current state, but it would be best to resolve the outstanding discussions before we merge.

xeenon and others added 2 commits August 31, 2021 16:40
index.bs Outdated Show resolved Hide resolved
Co-authored-by: Simeon Vincent <[email protected]>
@dotproto dotproto merged commit 020e8e2 into w3c:main Aug 31, 2021
dotproto pushed a commit to dotproto/webextensions that referenced this pull request Sep 1, 2021
Issue identified by @arasuni in a comment on PR w3c#61
dotproto pushed a commit to dotproto/webextensions that referenced this pull request Sep 1, 2021
Issue identified by @ariasuni in a comment on PR w3c#61
xeenon pushed a commit that referenced this pull request Sep 2, 2021
Issue identified by @ariasuni in a comment on PR #61
Copy link

@making787 making787 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants