BREAKING CHANGE: argument + default types should be string #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's weird that the this had not been caught earlier. |
marcoscaceres
changed the title
saschanaz
approved these changes
Oct 26, 2017
|
What was the reason for this change? How should I get the value as a JS Number primitive? Is there any danger in doing Perhaps most vitally, given a value that isn't representable as a JS Number, does the rounding happen in the right way to match what would happen with a |
gsnedders
added a commit
to gsnedders/web-platform-tests
that referenced
this pull request
Nov 5, 2017
gsnedders
added a commit
to gsnedders/web-platform-tests
that referenced
this pull request
Nov 5, 2017
This is because of #94, where the parsed result does not provide the original number literals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.