-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend RTCIceTransport to allow changing the selected candidate pair #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a race condition where an application might cause state to change from within an event handler.
If nomination is being deferred, either side is allowed to send on a pair of their choosing. Only nomination is the exclusive prerogative the controlling agent.
This issue was mentioned in WEBRTCWG-2023-09-12 (Page 65) |
sam-vi
changed the title
Set selected candidate pair
Extend RTCIceTransport to allow changing the selected candidate pair
Sep 22, 2023
This was referenced Oct 4, 2023
jan-ivar
approved these changes
Oct 26, 2023
aboba
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171.
This PR extends the
RTCIceTransport
interface by adding a new event handler attribute and a method which together allow an application to control the candidate pair used for sending and receiving data over a peer connection.A new, cancelable event
icecandidatepairnominate
is proposed to allow an application to defer the nomination of a candidate pair by the ICE agent as the selected candidate pair for transport. This allows the selected candidate pair to be changed without an ICE restart.A new method
setSelectedCandidatePair
is proposed to allow an application to set any valid candidate pair as the selected candidate pair from which to send data.Preview | Diff