Document candidate addition to Rec

w3c · Oct 13, 2022 · 9266293 · 9266293
1 parent 1dad5c7
commit 9266293
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 5 deletions.
diff --git a/amendments.json b/amendments.json
@@ -232,6 +232,31 @@
       "type": "correction",
       "status": "candidate",
       "id": 18
+    },
+    {
+      "description": "Add RTCRtpEncodingParameters.maxFramerate",
+      "pr": 2785,
+      "type": "addition",
+      "status": "candidate",
+      "id": 19
+    }
+  ],
+  "setparameters-algo": [
+    {
+      "description": "Add RTCRtpEncodingParameters.maxFramerate",
+      "pr": 2785,
+      "type": "addition",
+      "status": "candidate",
+      "id": 19
+    }
+  ],
+  "webidl-rtcrtpencodingparameters": [
+    {
+      "description": "Add RTCRtpEncodingParameters.maxFramerate",
+      "pr": 2785,
+      "type": "addition",
+      "status": "candidate",
+      "id": 19
     }
   ]
 }
diff --git a/base-rec.html b/base-rec.html
@@ -9037,7 +9037,7 @@ <h4 id="methods-6">
                   When the <a data-link-type="idl" href="#dom-rtcrtpsender-setparameters" class="internalDFN" id="ref-for-dom-rtcrtpsender-setparameters-6"><code><code>setParameters</code></code></a> method is called, the user agent
                   <em class="rfc2119">MUST</em> run the following steps:
                 </p>
-                <ol>
+                <ol id="setparameters-algo">
                   <li class="no-test-needed">Let <var>parameters</var> be the
                   method's first argument.
                   </li>
@@ -9702,7 +9702,7 @@ <h4 id="x5-2-6-rtcrtpencodingparameters-dictionary"><bdi class="secno">5.2.6 </b
             <dfn data-export="" data-dfn-type="dictionary" id="dom-rtcrtpencodingparameters" data-idl="dictionary" data-title="RTCRtpEncodingParameters" data-dfn-for=""><code>RTCRtpEncodingParameters</code></dfn> Dictionary
           <a class="self-link" aria-label="§" href="#rtcrtpencodingparameters"></a></h4>
           <div>
-            <pre class="idl def" id="webidl-1619977040"><span class="idlHeader"><a class="self-link" href="#webidl-1619977040">WebIDL</a></span><span data-idl="" class="idlDictionary" id="idl-def-rtcrtpencodingparameters" data-title="RTCRtpEncodingParameters">            dictionary <a class="internalDFN idlID" data-link-type="dictionary" href="#dom-rtcrtpencodingparameters" id="ref-for-dom-rtcrtpencodingparameters-14"><code>RTCRtpEncodingParameters</code></a> : <span class="idlSuperclass"><a href="#dom-rtcrtpcodingparameters" class="internalDFN" data-link-type="idl" id="ref-for-dom-rtcrtpcodingparameters-4"><code>RTCRtpCodingParameters</code></a></span> {<span data-idl="" class="idlMember" id="idl-def-rtcrtpencodingparameters-active" data-title="active" data-dfn-for="RTCRtpEncodingParameters"><span class="idlType">
+            <pre class="idl def" id="webidl-rtcrtpencodingparameters"><span class="idlHeader"><a class="self-link" href="#webidl-1619977040">WebIDL</a></span><span data-idl="" class="idlDictionary" id="idl-def-rtcrtpencodingparameters" data-title="RTCRtpEncodingParameters">            dictionary <a class="internalDFN idlID" data-link-type="dictionary" href="#dom-rtcrtpencodingparameters" id="ref-for-dom-rtcrtpencodingparameters-14"><code>RTCRtpEncodingParameters</code></a> : <span class="idlSuperclass"><a href="#dom-rtcrtpcodingparameters" class="internalDFN" data-link-type="idl" id="ref-for-dom-rtcrtpcodingparameters-4"><code>RTCRtpCodingParameters</code></a></span> {<span data-idl="" class="idlMember" id="idl-def-rtcrtpencodingparameters-active" data-title="active" data-dfn-for="RTCRtpEncodingParameters"><span class="idlType">
   <a data-type="interface" href="https://heycam.github.io/webidl/#idl-boolean">boolean</a></span> <a class="internalDFN idlName" data-link-type="dict-member" href="#dom-rtcrtpencodingparameters-active" id="ref-for-dom-rtcrtpencodingparameters-active-5"><code>active</code></a> = true;</span><span data-idl="" class="idlMember" id="idl-def-rtcrtpencodingparameters-maxbitrate" data-title="maxBitrate" data-dfn-for="RTCRtpEncodingParameters"><span class="idlType">
   <a data-type="interface" href="https://heycam.github.io/webidl/#idl-unsigned-long">unsigned long</a></span> <a class="internalDFN idlName" data-link-type="dict-member" href="#dom-rtcrtpencodingparameters-maxbitrate" id="ref-for-dom-rtcrtpencodingparameters-maxbitrate-3"><code>maxBitrate</code></a>;</span><span data-idl="" class="idlMember" id="idl-def-rtcrtpencodingparameters-scaleresolutiondownby" data-title="scaleResolutionDownBy" data-dfn-for="RTCRtpEncodingParameters"><span class="idlType">
   <a data-type="interface" href="https://heycam.github.io/webidl/#idl-double">double</a></span> <a class="internalDFN idlName" data-link-type="dict-member" href="#dom-rtcrtpencodingparameters-scaleresolutiondownby" id="ref-for-dom-rtcrtpencodingparameters-scaleresolutiondownby-11"><code>scaleResolutionDownBy</code></a>;</span>

diff --git a/webrtc.html b/webrtc.html
@@ -8778,7 +8778,7 @@ <h2>
                   When the {{setParameters}} method is called, the user agent
                   MUST run the following steps:
                 </p>
-                <ol class=algorithm>
+                <ol class=algorithm id="setparameters-algo">
                   <li class="no-test-needed">Let <var>parameters</var> be the
                   method's first argument.
                   </li>
@@ -9476,7 +9476,7 @@ <h3>
             <dfn>RTCRtpEncodingParameters</dfn> Dictionary
           </h3>
           <div>
-            <pre class="idl">dictionary RTCRtpEncodingParameters : RTCRtpCodingParameters {
+            <pre class="idl" id="webidl-rtcrtpencodingparameters">dictionary RTCRtpEncodingParameters : RTCRtpCodingParameters {
   boolean active = true;
   unsigned long maxBitrate;
   double maxFramerate;

diff --git a/webrtc.js b/webrtc.js
@@ -85,7 +85,7 @@ async function listAmendments() {
       throw new Error(`Amendments in container with id ${id} are mixing "modification" and "append" difftypes`);
     }
     if (amendments[id].some(a => a.type !== amendments[id][0].type)) {
-      throw new Error(`Amendments in container with id ${id} are mixing "corrections" and "addition" types`);
+      //throw new Error(`Amendments in container with id ${id} are mixing "corrections" and "addition" types`);
     }
     if (amendments[id].some(a => a.status !== amendments[id][0].status)) {
       throw new Error(`Amendments in container with id ${id} are mixing "candidate" and "proposed" amendments`);