Merge pull request #2909 from w3c/binarytype-setter

Fix binaryType setter requirements
w3c · Nov 16, 2023 · c9901ed · c9901ed
2 parents 1804e42 + f374868
commit c9901ed
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 10 deletions.
diff --git a/amendments.json b/amendments.json
@@ -529,5 +529,17 @@
       "status": "candidate",
       "id": 38
     }
+  ],
+  "dom-datachannel-binarytype-desc": [
+    {
+      "description": "Fix binaryType setter requriements",
+      "pr": 2909,
+      "type": "correction",
+      "status": "candidate",
+      "tests": [
+	"webrtc/RTCDataChannel-binaryType.window.js"
+      ],
+      "id": 39
+    }
   ]
 }
diff --git a/base-rec.html b/base-rec.html
@@ -14120,7 +14120,7 @@ <h4 id="attributes-17">
                 <dfn id="dom-datachannel-binarytype" data-export="" data-dfn-type="attribute" data-idl="attribute" data-title="binaryType" data-dfn-for="RTCDataChannel" data-type="BinaryType" data-lt="binaryType" data-local-lt="RTCDataChannel.binaryType"><code>binaryType</code></dfn> of type
                 <span class="idlAttrType">BinaryType</span>
               </dt>
-              <dd>
+              <dd id="dom-datachannel-binarytype-desc">
                 <p class="needs-tests">
                   The <a data-link-type="idl" href="#dom-datachannel-binarytype" class="internalDFN" id="ref-for-dom-datachannel-binarytype-5"><code><code>binaryType</code></code></a> attribute <em class="rfc2119">MUST</em>, on getting, return the
                   value to which it was last set. On setting, if the new value

diff --git a/webrtc.html b/webrtc.html
@@ -14438,18 +14438,14 @@ <h2>
                 <dfn id="dom-datachannel-binarytype">binaryType</dfn> of type
                 <span class="idlAttrType">BinaryType</span>
               </dt>
-              <dd>
+              <dd id="dom-datachannel-binarytype-desc">
                 <p>
-                  The {{binaryType}} attribute MUST, on getting, return the
-                  value to which it was last set. On setting, if the new value
-                  is either the string <code class="html">"blob"</code> or the
-                  string <code class="html">"arraybuffer"</code>, then set the
-                  IDL attribute to this new value. Otherwise, [=
-                  exception/throw =] a {{SyntaxError}}. <span data-tests=
+                  The {{binaryType}} attribute returns the
+                  value to which it was last set. <span data-tests=
                   "RTCPeerConnection-createDataChannel.html">When an
                   {{RTCDataChannel}} object is created, the
-                  {{RTCDataChannel/binaryType}} attribute MUST be initialized
-                  to the string <code class="html">"blob"</code>.</span>
+                  {{binaryType}} attribute MUST be initialized
+                  to the string {{BinaryType/"blob"}}.</span>
                 </p>
                 <p>
                   This attribute controls how binary data is exposed to