Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setCodecPreferences should take sequence<RTCRtpCodec> #2959

Closed
jan-ivar opened this issue Apr 17, 2024 · 0 comments · Fixed by #2960
Closed

setCodecPreferences should take sequence<RTCRtpCodec> #2959

jan-ivar opened this issue Apr 17, 2024 · 0 comments · Fixed by #2960
Assignees

Comments

@jan-ivar
Copy link
Member

setCodecPreferences's WebIDL currently looks like this:

undefined setCodecPreferences(sequence<RTCRtpCodecCapability> codecs);

...but it should probably be:

undefined setCodecPreferences(sequence<RTCRtpCodec> codecs);

...based on my understanding of intent which is to allow inputs from both capabilities and parameters:

transceiver.setCodecPreferences(RTCRtpReceiver.getCapabilities("video").codecs); // RTCRtpCodecCapability
transceiver.setCodecPreferences(receiver.getParameters().codecs);                // RTCRtpCodecParameters

This seems editorial to fix still, given:
image
image
...but seems like something we should fix now to have the right extension points in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant