-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document substantive changes since Rec as candidate amendments #2713
Conversation
The process to add a candidate change with this approach is to add a description of the change based on the following template: <div class=correction id="change-prXXXX">
<p><span class=title><!-- Description that can be used a summary of the change --></span>
is a candidate correction -
see <a href="https://github.com/w3c/webrtc-pc/pull/XXXX">its associated pull request</a>.</p>
</div> and inserts it in the document close to where the substantive changes were made. It uses the number of the relevant pull request mostly as a way to find an easily-relevant, hard-to-duplicate identifier, but no particular magic is associated with that number at the moment. In particular, if a change is best described as associated to several pull requests, picking any of these as the source of the number can work. If several distant sections are concerned, further instance of that notice can be inserted by simply adding an empty <div class=correction id="change-prXXXX-N"></div> where N is the incremented value of the number of these notices. The ReSpec pre-processing script then takes care of adding the numbered "Candidate Correction" markers, and of listing and linking them in the "Candidate Amendments" appendix. |
Reporting from my discussion with @plehegar :
I'll iterate in that direction (probably starting with the latter that would avoid creating confusing doppelgangers) |
41c8e7c
to
dc24600
Compare
@alvestrand @caribouW3 @plehegar I have now taken another stab at this that fulfills the process requirements as I understand them from @plehegar while still reducing the editing burden substantially (although whether it reduces it enough is something I'm looking for @alvestrand feedback). The result of this work is that:
I've tried documenting the required steps for integrating an amendment in the draft in |
For illustration purposes, I've gone through the exercise of what it would take to import transferable data channels from WebRTC extensions to the main spec as a candidate addition: dontcallmedom#2 - dontcallmedom@aaed6af is the work needed on top of the spec work to markup the changes as Rec-ready amendments The same mechanism could be used to bring that section in the editors draft and mark it up as "addition under investigation" there (completely independently of the Rec amendments process), as an alternative to maintaining it in the separate webrtc-extensions repo. |
Limitations: | ||
* does not allow to handle different type of changes ("modification" vs "append") in a single section - treating all of them as modification should suffice in such a situation | ||
* does not allow to handle different type of amendment ("correction" vs "addition") or different status of amendment ("candidate" vs "proposed") in a single section - the only alternative is to find a lower granularity section should that be needed | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how would you mark up a section that is changed multiple times?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes for section id "dictionary-rtcconfiguration-members" in the pull request illustrates a section with two changes. In general, you don't have to mark them up, you just have to describe the changes in amendments.json, and the script takes care of showing the current rec vs the proposed new text.
@plehegar have you had a chance to check if the results match what you expect would be acceptable for an updated Rec? |
b71fe1e
to
3c72916
Compare
@plehegar indicated offline that this approach should pass muster, so I'm now marking it as ready for review & merging, which will help completing upcoming pull requests with additional substantive changes to document them with this mechanism. |
Note: the generated version seemed to have a number of respec errors. Those probably need to be hunted down during the merge process. |
976b4d8
to
474a100
Compare
I've rebased to main and updated the sample, which removes the said respec errors (the ones that remain are "expected"). |
modified with display:none and robots-noindex to avoid any unintended human use
to be processed by scripting
also simplify somewhat the assumptions on marking up amended sections
474a100
to
cc9770d
Compare
Avoid respec warning
I've updated this with all the latest PR that got merged; it would be great to merge this to ensure new substantive changes can be directly annotated using this mechanism, and to experiment with annotating less mature changes as well (as mentioned in #2770 |
merging as agreed with the chairs |
…tion Help ensure the infrastructure set up in #2713 is systematically used
This pull request is a proposed approach to document the various substantive changes we've brought to the spec since it was published as a Recommendation to make it acceptable as part of the process to amend W3C recommendations.
Preview | Diff