Update sendEncodings validation and initialization. #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-ivar
changed the title
This was referenced Sep 29, 2022
|
@alvestrand if you could take a look at this one that would be great! |
alvestrand
approved these changes
Oct 13, 2022
|
@dontcallmedom this PR isn't 100% editorial since it fixes #2730. Do you want to take care of adding the amendments? |
|
if you could do it as the same time of documenting #2758 that would be appreciated :) |
jan-ivar
added a commit
to jan-ivar/webrtc-pc
that referenced
this pull request
Oct 13, 2022
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2730. @docfaraday PTAL. Ignore-whitespace diff recommended.
Preview | Diff