Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix binaryType setter requirements #2909

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fix binaryType setter requirements #2909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66a578f
Fix binaryType setter requirements
dontcallmedom Nov 15, 2023
f374868
Add relevant amendment description
dontcallmedom Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions amendments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,5 +529,17 @@
"status": "candidate",
"id": 38
}
],
"dom-datachannel-binarytype-desc": [
{
"description": "Fix binaryType setter requriements",
"pr": 2909,
"type": "correction",
"status": "candidate",
"tests": [
"webrtc/RTCDataChannel-binaryType.window.js"
],
"id": 39
}
]
}
2 changes: 1 addition & 1 deletion base-rec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14120,7 +14120,7 @@ <h4 id="attributes-17">
<dfn id="dom-datachannel-binarytype" data-export="" data-dfn-type="attribute" data-idl="attribute" data-title="binaryType" data-dfn-for="RTCDataChannel" data-type="BinaryType" data-lt="binaryType" data-local-lt="RTCDataChannel.binaryType"><code>binaryType</code></dfn> of type
<span class="idlAttrType">BinaryType</span>
</dt>
<dd>
<dd id="dom-datachannel-binarytype-desc">
<p class="needs-tests">
The <a data-link-type="idl" href="#dom-datachannel-binarytype" class="internalDFN" id="ref-for-dom-datachannel-binarytype-5"><code><code>binaryType</code></code></a> attribute <em class="rfc2119">MUST</em>, on getting, return the
value to which it was last set. On setting, if the new value
Expand Down
14 changes: 5 additions & 9 deletions webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14438,18 +14438,14 @@ <h2>
<dfn id="dom-datachannel-binarytype">binaryType</dfn> of type
<span class="idlAttrType">BinaryType</span>
</dt>
<dd>
<dd id="dom-datachannel-binarytype-desc">
<p>
The {{binaryType}} attribute MUST, on getting, return the
value to which it was last set. On setting, if the new value
is either the string <code class="html">"blob"</code> or the
string <code class="html">"arraybuffer"</code>, then set the
IDL attribute to this new value. Otherwise, [=
exception/throw =] a {{SyntaxError}}. <span data-tests=
The {{binaryType}} attribute returns the
value to which it was last set. <span data-tests=
"RTCPeerConnection-createDataChannel.html">When an
{{RTCDataChannel}} object is created, the
{{RTCDataChannel/binaryType}} attribute MUST be initialized
to the string <code class="html">"blob"</code>.</span>
{{binaryType}} attribute MUST be initialized
to the string {{BinaryType/"blob"}}.</span>
</p>
<p>
This attribute controls how binary data is exposed to
Expand Down
Loading