make setCodecPreferences only look at receive codecs #2926

fippo · 2024-01-16T16:32:12Z

aligning with JSEP:

setCodecPreferences does not directly affect which codec the implementation decides to send.
It only affects which codecs the implementation indicates that it prefers to receive

partial fix for #2888

💥 Error: 502 Bad Gateway 💥

PR Preview failed to build. (Last tried on Feb 1, 2024, 5:14 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

error code: 502

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

stefhak · 2024-01-18T10:12:08Z

LGTM.

alvestrand

Discussed in the January 16 WEBRTC WG meeting. I believe this PR is consistent with the outcome of that discussion.

tracking w3c/webrtc-pc#2926 * tests now use RTCRtpReceiver.getCapabilities instead of RTCRtpSender * added test that a sendonly codec throws InvalidModificationError WebRTC change: https://webrtc-review.googlesource.com/c/src/+/328780 BUG=webrtc:15396 Remove obsolete WebRtc-ExposeNonStandardStats feature which broke when stats were moved to using WebIDL BUG=chromium:1323230,chromium:1414363 Change-Id: I690b76caf171a8c5ace41badf3b66cd90ffb596d

fippo · 2024-01-31T12:56:29Z

Test added in web-platform-tests/wpt#44318

tracking w3c/webrtc-pc#2926 * tests now use RTCRtpReceiver.getCapabilities instead of RTCRtpSender * added test that a sendonly codec throws InvalidModificationError WebRTC change: https://webrtc-review.googlesource.com/c/src/+/328780 BUG=webrtc:15396 Remove obsolete WebRtc-ExposeNonStandardStats feature which broke when stats were moved to using WebIDL BUG=chromium:1323230,chromium:1414363 Change-Id: I690b76caf171a8c5ace41badf3b66cd90ffb596d

tracking w3c/webrtc-pc#2926 * tests now use RTCRtpReceiver.getCapabilities instead of RTCRtpSender * added test that a sendonly codec throws InvalidModificationError WebRTC change: https://webrtc-review.googlesource.com/c/src/+/328780 BUG=webrtc:15396 Change-Id: I690b76caf171a8c5ace41badf3b66cd90ffb596d

fippo · 2024-02-01T13:06:13Z

Amendment worked but validation now throws
"file:/home/runner/work/webrtc-pc/webrtc-pc.w3c/webrtc.html":13397.15-13397.67: error: Element “div” not allowed as child of element “dl” in this context. (Suppressing further errors from this subtree.)
but I am not touching a dl, only a dt? @dontcallmedom you are my only hope!

dontcallmedom · 2024-02-01T13:10:57Z

#2910 had the same bogus error, which I didn't quite get to debug; will raise again in my todo list :)

Ensure generation of valid markup

henbos · 2024-02-02T10:25:42Z

webrtc.html

@@ -11181,9 +11181,10 @@ <h2>
                <dfn data-idl="">setCodecPreferences</dfn>
              </dt>
              <dd>
+		<div id="setcodecpreferences-receive">


I think I found one more place we forgot to upate. Should we also delete this sentence?

https://w3c.github.io/webrtc-pc/#dfn-final-steps-to-create-an-answer says

If transceiver.direction is "sendonly" or "sendrecv", exclude any codecs not included in the list of implemented send codecs for kind.

Since it should be OK for pc1 to receive X and pc2 to receive Y, we shouldn't filter the preference on send codecs because that would exclude X from pc1's offer if X was a recvonly codec.

That sentence needs to stay. Until we are ready to more officially deal with answer codecs that are not in the offer which JSEP allows.

webrtc.html

henbos

There be dragons

henbos

Removing my approval because I think I've identified that this PR breaks sendonly use cases without modifying SDP and considering we already have a transciever.direction filtering in place, I don't see any problem with what the spec says today. See #2932 (comment)

fippo · 2024-02-08T09:19:40Z

Can you give an example of a sendonly codec?

henbos

Suspecting what I was reacting to was an implementation bug, not a spec issue. Approving again

webrtc.html

alvestrand · 2024-02-08T15:09:26Z

Editors can integrate once tests have landed (and @dontcallmedom has ensured that amendment thingy is right.

which is what is noted in JSEP: https://www.rfc-editor.org/rfc/rfc8829.html#name-setcodecpreferences Some W3C spec modifications are required since the W3C specification currently takes into account send codecs as well. Spec issue: w3c/webrtc-pc#2888 Spec PR: w3c/webrtc-pc#2926 setCodecPreferences continues to modify the codecs in an offer. Also rename RtpSender::SetCodecPreferences to RtpSender::SetSendCodecs for consistent semantics. BUG=webrtc:15396 Change-Id: I1e8fbe77cb2670575578a777ed1336567a1e4031 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328780 Reviewed-by: Henrik Boström <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#41719}

This reverts commit 1cce1d7. Reason for revert: Breaks WPTs Original change's description: > Make setCodecPreferences only look at receive codecs > > which is what is noted in JSEP: > https://www.rfc-editor.org/rfc/rfc8829.html#name-setcodecpreferences > > Some W3C spec modifications are required since the W3C specification > currently takes into account send codecs as well. > > Spec issue: > w3c/webrtc-pc#2888 > Spec PR: > w3c/webrtc-pc#2926 > > setCodecPreferences continues to modify the codecs in an offer. > > Also rename RtpSender::SetCodecPreferences to RtpSender::SetSendCodecs for consistent semantics. > > BUG=webrtc:15396 > > Change-Id: I1e8fbe77cb2670575578a777ed1336567a1e4031 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328780 > Reviewed-by: Henrik Boström <[email protected]> > Commit-Queue: Philipp Hancke <[email protected]> > Reviewed-by: Harald Alvestrand <[email protected]> > Cr-Commit-Position: refs/heads/main@{#41719} Bug: webrtc:15396 Change-Id: I7b545e91f820c3affc39841c6e93939eac75c363 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339520 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Owners-Override: Henrik Boström <[email protected]> Reviewed-by: Henrik Boström <[email protected]> Auto-Submit: Henrik Boström <[email protected]> Bot-Commit: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#41725}

dontcallmedom-bot · 2024-02-21T07:47:37Z

This issue was mentioned in WEBRTCWG-2024-02-20 (Page 18)

This is a reland of commit 1cce1d7 after updating the WPT that broke on Mac. Original change's description: > Make setCodecPreferences only look at receive codecs > > which is what is noted in JSEP: > https://www.rfc-editor.org/rfc/rfc8829.html#name-setcodecpreferences > > Some W3C spec modifications are required since the W3C specification > currently takes into account send codecs as well. > > Spec issue: > w3c/webrtc-pc#2888 > Spec PR: > w3c/webrtc-pc#2926 > > setCodecPreferences continues to modify the codecs in an offer. > > Also rename RtpSender::SetCodecPreferences to RtpSender::SetSendCodecs for consistent semantics. > > BUG=webrtc:15396 > > Change-Id: I1e8fbe77cb2670575578a777ed1336567a1e4031 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328780 > Reviewed-by: Henrik Boström <[email protected]> > Commit-Queue: Philipp Hancke <[email protected]> > Reviewed-by: Harald Alvestrand <[email protected]> > Cr-Commit-Position: refs/heads/main@{#41719} Bug: webrtc:15396 Change-Id: I0c7b17f00de02286f176b500460e17980b83b35b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339541 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#41807}

Essentially a no-op since we're going to see this change reverted when we vendor in 1e7a6f3b6a. Upstream commit: https://webrtc.googlesource.com/src/+/1cce1d7ddcbde3a3648007b5a131bd0c2638724b Make setCodecPreferences only look at receive codecs which is what is noted in JSEP: https://www.rfc-editor.org/rfc/rfc8829.html#name-setcodecpreferences Some W3C spec modifications are required since the W3C specification currently takes into account send codecs as well. Spec issue: w3c/webrtc-pc#2888 Spec PR: w3c/webrtc-pc#2926 setCodecPreferences continues to modify the codecs in an offer. Also rename RtpSender::SetCodecPreferences to RtpSender::SetSendCodecs for consistent semantics. BUG=webrtc:15396 Change-Id: I1e8fbe77cb2670575578a777ed1336567a1e4031 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328780 Reviewed-by: Henrik Boström <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#41719}

We already cherry-picked this when we vendored 1cce1d7ddc. Upstream commit: https://webrtc.googlesource.com/src/+/1e7a6f3b6a8eee7efcb129eec10fe734d718ebc8 Revert "Make setCodecPreferences only look at receive codecs" This reverts commit 1cce1d7ddcbde3a3648007b5a131bd0c2638724b. Reason for revert: Breaks WPTs Original change's description: > Make setCodecPreferences only look at receive codecs > > which is what is noted in JSEP: > https://www.rfc-editor.org/rfc/rfc8829.html#name-setcodecpreferences > > Some W3C spec modifications are required since the W3C specification > currently takes into account send codecs as well. > > Spec issue: > w3c/webrtc-pc#2888 > Spec PR: > w3c/webrtc-pc#2926 > > setCodecPreferences continues to modify the codecs in an offer. > > Also rename RtpSender::SetCodecPreferences to RtpSender::SetSendCodecs for consistent semantics. > > BUG=webrtc:15396 > > Change-Id: I1e8fbe77cb2670575578a777ed1336567a1e4031 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328780 > Reviewed-by: Henrik Boström <[email protected]> > Commit-Queue: Philipp Hancke <[email protected]> > Reviewed-by: Harald Alvestrand <[email protected]> > Cr-Commit-Position: refs/heads/main@{#41719} Bug: webrtc:15396 Change-Id: I7b545e91f820c3affc39841c6e93939eac75c363 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339520 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Owners-Override: Henrik Boström <[email protected]> Reviewed-by: Henrik Boström <[email protected]> Auto-Submit: Henrik Boström <[email protected]> Bot-Commit: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#41725}

Essentially a no-op since we're going to see this change reverted when we vendor in 1e7a6f3b6a. Upstream commit: https://webrtc.googlesource.com/src/+/1cce1d7ddcbde3a3648007b5a131bd0c2638724b Make setCodecPreferences only look at receive codecs which is what is noted in JSEP: https://www.rfc-editor.org/rfc/rfc8829.html#name-setcodecpreferences Some W3C spec modifications are required since the W3C specification currently takes into account send codecs as well. Spec issue: w3c/webrtc-pc#2888 Spec PR: w3c/webrtc-pc#2926 setCodecPreferences continues to modify the codecs in an offer. Also rename RtpSender::SetCodecPreferences to RtpSender::SetSendCodecs for consistent semantics. BUG=webrtc:15396 Change-Id: I1e8fbe77cb2670575578a777ed1336567a1e4031 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328780 Reviewed-by: Henrik Boström <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#41719}

We already cherry-picked this when we vendored 1cce1d7ddc. Upstream commit: https://webrtc.googlesource.com/src/+/1e7a6f3b6a8eee7efcb129eec10fe734d718ebc8 Revert "Make setCodecPreferences only look at receive codecs" This reverts commit 1cce1d7ddcbde3a3648007b5a131bd0c2638724b. Reason for revert: Breaks WPTs Original change's description: > Make setCodecPreferences only look at receive codecs > > which is what is noted in JSEP: > https://www.rfc-editor.org/rfc/rfc8829.html#name-setcodecpreferences > > Some W3C spec modifications are required since the W3C specification > currently takes into account send codecs as well. > > Spec issue: > w3c/webrtc-pc#2888 > Spec PR: > w3c/webrtc-pc#2926 > > setCodecPreferences continues to modify the codecs in an offer. > > Also rename RtpSender::SetCodecPreferences to RtpSender::SetSendCodecs for consistent semantics. > > BUG=webrtc:15396 > > Change-Id: I1e8fbe77cb2670575578a777ed1336567a1e4031 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328780 > Reviewed-by: Henrik Boström <[email protected]> > Commit-Queue: Philipp Hancke <[email protected]> > Reviewed-by: Harald Alvestrand <[email protected]> > Cr-Commit-Position: refs/heads/main@{#41719} Bug: webrtc:15396 Change-Id: I7b545e91f820c3affc39841c6e93939eac75c363 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339520 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Owners-Override: Henrik Boström <[email protected]> Reviewed-by: Henrik Boström <[email protected]> Auto-Submit: Henrik Boström <[email protected]> Bot-Commit: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#41725}

This reverts commit 1cce1d7. Reason for revert: Breaks WPTs Original change's description: > Make setCodecPreferences only look at receive codecs > > which is what is noted in JSEP: > https://www.rfc-editor.org/rfc/rfc8829.html#name-setcodecpreferences > > Some W3C spec modifications are required since the W3C specification > currently takes into account send codecs as well. > > Spec issue: > w3c/webrtc-pc#2888 > Spec PR: > w3c/webrtc-pc#2926 > > setCodecPreferences continues to modify the codecs in an offer. > > Also rename RtpSender::SetCodecPreferences to RtpSender::SetSendCodecs for consistent semantics. > > BUG=webrtc:15396 > > Change-Id: I1e8fbe77cb2670575578a777ed1336567a1e4031 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328780 > Reviewed-by: Henrik Boström <[email protected]> > Commit-Queue: Philipp Hancke <[email protected]> > Reviewed-by: Harald Alvestrand <[email protected]> > Cr-Commit-Position: refs/heads/main@{#41719} Bug: webrtc:15396 Change-Id: I7b545e91f820c3affc39841c6e93939eac75c363 No-Presubmit: true No-Tree-Checks: true No-Try: true

Upstream commit: https://webrtc.googlesource.com/src/+/db2f52ba88cf9f98211df2dabb3f8aca9251c4a2 Reland "Make setCodecPreferences only look at receive codecs" This is a reland of commit 1cce1d7ddcbde3a3648007b5a131bd0c2638724b after updating the WPT that broke on Mac. Original change's description: > Make setCodecPreferences only look at receive codecs > > which is what is noted in JSEP: > https://www.rfc-editor.org/rfc/rfc8829.html#name-setcodecpreferences > > Some W3C spec modifications are required since the W3C specification > currently takes into account send codecs as well. > > Spec issue: > w3c/webrtc-pc#2888 > Spec PR: > w3c/webrtc-pc#2926 > > setCodecPreferences continues to modify the codecs in an offer. > > Also rename RtpSender::SetCodecPreferences to RtpSender::SetSendCodecs for consistent semantics. > > BUG=webrtc:15396 > > Change-Id: I1e8fbe77cb2670575578a777ed1336567a1e4031 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328780 > Reviewed-by: Henrik Boström <[email protected]> > Commit-Queue: Philipp Hancke <[email protected]> > Reviewed-by: Harald Alvestrand <[email protected]> > Cr-Commit-Position: refs/heads/main@{#41719} Bug: webrtc:15396 Change-Id: I0c7b17f00de02286f176b500460e17980b83b35b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339541 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#41807}

make setCodecPreferences only look at receive codecs

91e0c78

alvestrand approved these changes Jan 18, 2024

View reviewed changes

jan-ivar added the Needs Test Needs a WPT test label Jan 23, 2024

henbos approved these changes Jan 25, 2024

View reviewed changes

chromium-wpt-export-bot mentioned this pull request Jan 31, 2024

webrtc wpt: update setCodecPreferences tests for spec changes web-platform-tests/wpt#44318

Closed

try amendment

1a9e64c

Assign id of changed markup more granularly

2f1b2b8

Ensure generation of valid markup

henbos reviewed Feb 2, 2024

View reviewed changes

henbos mentioned this pull request Feb 8, 2024

Clarify a=rtpmap codec mappings should be offered even if the codec is not a preferred one #2932

Closed

henbos reviewed Feb 8, 2024

View reviewed changes

webrtc.html Show resolved Hide resolved

henbos reviewed Feb 8, 2024

View reviewed changes

henbos requested changes Feb 8, 2024

View reviewed changes

henbos approved these changes Feb 8, 2024

View reviewed changes

webrtc.html Show resolved Hide resolved

alvestrand added the Editors can integrate label Feb 8, 2024

jan-ivar approved these changes Feb 8, 2024

View reviewed changes

alvestrand merged commit 20474d9 into w3c:main Feb 8, 2024
4 checks passed

fippo deleted the setcodecpreferences-recvonly branch February 8, 2024 15:26

henbos mentioned this pull request Feb 14, 2024

Proposing setCodecPreferences to deal with both send and recv codecs #2939

Closed

dontcallmedom mentioned this pull request Sep 13, 2024

Publish Recommendation with Proposed Amendments #3001

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make setCodecPreferences only look at receive codecs #2926

make setCodecPreferences only look at receive codecs #2926

fippo commented Jan 16, 2024 •

edited by pr-preview bot

Loading

stefhak commented Jan 18, 2024

alvestrand left a comment

fippo commented Jan 31, 2024

fippo commented Feb 1, 2024

dontcallmedom commented Feb 1, 2024

henbos Feb 2, 2024

fippo Feb 2, 2024

henbos left a comment

henbos left a comment

fippo commented Feb 8, 2024

henbos left a comment

alvestrand commented Feb 8, 2024

dontcallmedom-bot commented Feb 21, 2024

make setCodecPreferences only look at receive codecs #2926

make setCodecPreferences only look at receive codecs #2926

Conversation

fippo commented Jan 16, 2024 • edited by pr-preview bot Loading

💥 Error: 502 Bad Gateway 💥

stefhak commented Jan 18, 2024

alvestrand left a comment

Choose a reason for hiding this comment

fippo commented Jan 31, 2024

fippo commented Feb 1, 2024

dontcallmedom commented Feb 1, 2024

henbos Feb 2, 2024

Choose a reason for hiding this comment

fippo Feb 2, 2024

Choose a reason for hiding this comment

henbos left a comment

Choose a reason for hiding this comment

henbos left a comment

Choose a reason for hiding this comment

fippo commented Feb 8, 2024

henbos left a comment

Choose a reason for hiding this comment

alvestrand commented Feb 8, 2024

dontcallmedom-bot commented Feb 21, 2024

fippo commented Jan 16, 2024 •

edited by pr-preview bot

Loading