Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test coverage annotation for sdp munging #2928

Merged
merged 1 commit into from
Feb 15, 2024
Merged

add test coverage annotation for sdp munging #2928

merged 1 commit into from
Feb 15, 2024

Conversation

fippo
Copy link
Contributor

@fippo fippo commented Jan 18, 2024 •
edited by pr-preview bot
Loading

@alvestrand
Copy link
Contributor

This led to a discussion about where a test for non-permitted behavior should be....

@fippo fippo mentioned this pull request Jan 26, 2024
Open
@alvestrand alvestrand merged commit 92bc258 into w3c:main Feb 15, 2024
3 of 4 checks passed
@fippo fippo deleted the dont-munge branch February 15, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youennf youennf youennf approved these changes

@Orphis Orphis Orphis approved these changes

Assignees
No one assigned
Labels
Editorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is it illegal to modify sdp between createOffer and setLocalDescription?
5 participants
@fippo @alvestrand @Orphis @youennf @aboba