Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in amendments #2949

Merged
merged 6 commits into from
Mar 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion amendments.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,25 @@ function listPRs(pr) {
return span;
}

function listTestUpdates(updates) {
const s = document.createElement("span");
if (updates === "not-testable") {
s.textContent = " (not testable)";
} else if (updates === "already-tested") {
s.textContent = " (no change needed in tests)";
} else if (Array.isArray(updates)) {
s.textContent = " - Changes to Web Platform Tests: ";
updates.forEach(u => {
const link = document.createElement("a");
link.href = "https://github.com/web-platform-tests/wpt/pull/" + u.split("#")[1];
link.textContent = "#" + u.split("#")[1];
s.append(link);
s.append(" ");
});
}
return s;
}

const capitalize = s => s[0].toUpperCase() + s.slice(1);

async function listAmendments() {
Expand Down Expand Up @@ -104,7 +123,7 @@ async function listAmendments() {
const li = document.createElement("li");
const entriesUl = document.createElement("ul");
li.appendChild(document.createTextNode(`${capitalize(status)} ${capitalize(type)} ${id}: `));
amendment.forEach(({description, section, pr}, i) => {
amendment.forEach(({description, section, pr, testUpdates}, i) => {
const entryLi = document.createElement("li");
entryLi.innerHTML = description;
const link = document.createElement("a");
Expand All @@ -113,6 +132,7 @@ async function listAmendments() {
link.textContent = `section ${titleFromId(section)}`;
entryLi.appendChild(link);
entryLi.appendChild(listPRs(pr));
entryLi.appendChild(listTestUpdates(testUpdates));
entriesUl.appendChild(entryLi);
});
li.appendChild(entriesUl);
Expand Down
76 changes: 43 additions & 33 deletions amendments.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@
],
"type": "correction",
"status": "candidate",
"id": "1"
"id": 1
},
{
"description": "Allow an implementation-defined limited to the number of configured ICE Servers",
"pr": 2679,
"type": "correction",
"status": "candidate",
"testUpdates": "not-testable",
"id": "2"
"id": 2
}
],
"set-the-configuration": [
Expand All @@ -38,7 +38,7 @@
],
"type": "correction",
"status": "candidate",
"id": "1"
"id": 1
},
{
"description": "Validate ICE transport settings upfront when setting a configuration",
Expand Down Expand Up @@ -71,7 +71,7 @@
"testUpdates": "already-tested",
"type": "correction",
"status": "candidate",
"id": "3"
"id": 3
}
],
"rtcpeerconnectionstate-description": [
Expand All @@ -84,7 +84,7 @@
"testUpdates": "already-tested",
"type": "correction",
"status": "candidate",
"id": "3"
"id": 3
},
{
"description": "Ensure the <code>connecting</code> state happens whenever a ICE or DTLS transport is new ",
Expand All @@ -97,7 +97,7 @@
],
"type": "correction",
"status": "candidate",
"id": "4"
"id": 4
}
],
"rtciceconnectionstate-description": [
Expand All @@ -110,7 +110,7 @@
"testUpdates": "already-tested",
"type": "correction",
"status": "candidate",
"id": "3"
"id": 3
}
],
"apply-description-restrictions": [
Expand All @@ -126,7 +126,7 @@
],
"type": "correction",
"status": "candidate",
"id": "5"
"id": 5
}
],
"rtccertificateexpiration-dictionary": [
Expand Down Expand Up @@ -203,7 +203,7 @@
"difftype": "modify",
"type": "correction",
"status": "candidate",
"id": 23
"id": 37
}
],
"simulcast-functionality": [
Expand All @@ -228,14 +228,23 @@
"type": "correction",
"status": "candidate",
"id": 12
},
{
"description": "Update explanation of simulcast envelope.",
"pr": 2814,
"testUpdates": "not-testable",
"difftype": "modify",
"type": "correction",
"status": "candidate",
"id": 28
}
],
"webidl-rtcicecandidate": [
{
"description": "Add RTCIceCandidate.relayProtocol",
"pr": 2763,
"tests": [
"idlharness.https.window.js"
"webrtc/idlharness.https.window.html"
],
"testUpdates": [
"web-platform-tests/wpt#36157"
Expand All @@ -261,7 +270,7 @@
"description": "Add RTCIceCandidate.relayProtocol",
"pr": 2763,
"tests": [
"idlharness.https.window.js"
"webrtc/idlharness.https.window.html"
],
"testUpdates": [
"web-platform-tests/wpt#36157"
Expand All @@ -275,7 +284,7 @@
"description": "Add RTCIceCandidate.url",
"pr": 2773,
"tests": [
"idlharness.https.window.js"
"webrtc/idlharness.https.window.html"
],
"testUpdates": [
"web-platform-tests/wpt#36572"
Expand Down Expand Up @@ -462,7 +471,7 @@
],
"type": "correction",
"status": "candidate",
"id": 24
"id": 13
},
{
"description": "Redefine SendCodecs and ReceiveCodecs",
Expand Down Expand Up @@ -490,10 +499,16 @@
"set-last-stable-offer-properties": [
{
"description": "Rollback restores ridless encoding trounced by sRD(simulcastOffer).",
"tests": [
"webrtc/simulcast/negotiation-encodings.https.html"
],
"testUpdates": [
"web-platform-tests/wpt#37477"
],
"pr": 2797,
"type": "addition",
"status": "candidate",
"id": 24
"id": 13
}
],
"set-rollback-per-transceiver": [
Expand All @@ -502,7 +517,13 @@
"pr": 2797,
"type": "addition",
"status": "candidate",
"id": 24
"tests": [
"webrtc/simulcast/negotiation-encodings.https.html"
],
"testUpdates": [
"web-platform-tests/wpt#37477"
],
"id": 13
}
],
"apply-remote-description": [
Expand Down Expand Up @@ -542,7 +563,7 @@
"difftype": "modify",
"type": "correction",
"status": "candidate",
"id": 23
"id": 37
},
{
"description": "Remove duplicate rids in proposedSendEncodings.",
Expand Down Expand Up @@ -619,18 +640,7 @@
"difftype": "modify",
"type": "correction",
"status": "candidate",
"id": 27
}
],
"simulcast-functionality": [
{
"description": "Update explanation of simulcast envelope.",
"pr": 2814,
"testUpdates": "not-testable",
"difftype": "modify",
"type": "correction",
"status": "candidate",
"id": 28
"id": 43
}
],
"rtcrtpcodecparameters": [
Expand Down Expand Up @@ -739,7 +749,7 @@
"description": "Prevent GC of non-closed RTCDataChannels",
"pr": 2902,
"tests": [
"webrtc/RTCDataChannel-GC.https.html"
"webrtc/RTCDataChannel-GC.html"
],
"testUpdates": [
"web-platform-tests/wpt#43369"
Expand All @@ -756,7 +766,7 @@
"type": "correction",
"status": "candidate",
"tests": [
"webrtc/RTCDataChannel-binaryType.window.js"
"webrtc/RTCDataChannel-binaryType.window.html"
],
"testUpdates": [
"web-platform-tests/wpt#41663"
Expand All @@ -769,7 +779,7 @@
"type": "correction",
"status": "candidate",
"tests": [
"webrtc/RTCDataChannel-binaryType.window.js",
"webrtc/RTCDataChannel-binaryType.window.html",
"webrtc/RTCDataChannel-send.html",
"webrtc/RTCPeerConnection-createDataChannel.html"
],
Expand All @@ -791,7 +801,7 @@
"testUpdates": [
"web-platform-tests/wpt#44318"
],
"id": 40
"id": 42
}
],
"setcodecpreferences-receive": [
Expand All @@ -806,7 +816,7 @@
"testUpdates": [
"web-platform-tests/wpt#44318"
],
"id": 40
"id": 42
}
],
"create-receiver-algo": [
Expand Down
2 changes: 0 additions & 2 deletions webrtc.css
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ body ins, body del { display: block; }
body * ins, body * del { display: inline; }


li > span:not([title=""]):not([class="XXX"]):not([class="impl"]):not([class="note"]) { border-bottom: solid #99CC99; }

.note { color: green; background: transparent; font-family: sans-serif, Droid Sans Fallback; }
.warning { color: red; background: transparent; }
.note, .warning { font-weight: bolder; font-style: italic; }
Expand Down
Loading