Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to "codec dictionary match" algorithm and remove index consistency claim #2958

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Apr 17, 2024

Fixes #2955.

Once merged, links in the following places would need to be updated:

  1. https://w3c.github.io/webrtc-extensions/#addtransceiver

Preview | Diff

@jan-ivar jan-ivar requested a review from aboba April 17, 2024 16:10
@jan-ivar jan-ivar self-assigned this Apr 17, 2024
@jan-ivar jan-ivar changed the title Rename to "codec dictionary match" algorithm and remove index consiency claim Rename to "codec dictionary match" algorithm and remove index consistency claim Apr 17, 2024
@alvestrand
Copy link
Contributor

Why rename?
I can't see anything else that needs to use the name "codec match", and as pointed out in the CL, renaming makes extra work in multiple other places. I fail to see the benefit of that.

The other changes in the CL look fine to me.

@jan-ivar
Copy link
Member Author

@jan-ivar to merge a PR for https://w3c.github.io/webrtc-extensions/#addtransceiver right after merging this.

@jan-ivar jan-ivar merged commit f0aa1a9 into w3c:main Apr 18, 2024
3 checks passed
@jan-ivar jan-ivar deleted the setcodecprefs branch April 18, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusion over duplicates in setCodecPreferences? Why allow them?
2 participants