This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Respect multiple headers with the same name in .headers files. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 82.12% (diff: 100%)@@ master #95 diff @@
==========================================
Files 24 24
Lines 1991 1992 +1
Methods 0 0
Messages 0 0
Branches 283 283
==========================================
+ Hits 1635 1636 +1
Misses 237 237
Partials 119 119
|
|
Reviewed 3 of 3 files at r1. Comments from Reviewable |
|
Do we just merge them all into one server-side? Because #90 is partly concerned about the case when browsers don't merge them client-side, and testing whether or not they get merged. I guess maybe that's something to handle with .asis? |
|
We should send them as separate headers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90.
This change is