Initial commit for #279. #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeaVerou
reviewed
Jul 26, 2022
LeaVerou
reviewed
Jul 26, 2022
hober
approved these changes
Jul 26, 2022
LeaVerou
reviewed
Jul 26, 2022
index.bs
Outdated
| should always have a corresponding IDL attribute with the same name, | ||
| and the state between the two should be kept synchronized. | ||
| Carving out a synchronized IDL attribute with inconsistent naming | ||
| results in confusion, and should be avoided at all costs. |
There was a problem hiding this comment.
And we should definitely mention the classic examples of <input value> / <input checked> somewhere in this.
LeaVerou
reviewed
Jul 26, 2022
|
|
||
| <div class="note"> | ||
| This does not hold the other way around. | ||
| A new IDL attribute does not always warrant a content attribute counterpart. |
There was a problem hiding this comment.
This needs an example of an IDL attribute that does not correspond to an HTML attribute.
Co-authored-by: Lea Verou <[email protected]>
Co-authored-by: Theresa O'Connor <[email protected]>
Co-authored-by: Theresa O'Connor <[email protected]>
Co-authored-by: Theresa O'Connor <[email protected]>
LeaVerou
reviewed
Jul 26, 2022
Co-authored-by: Lea Verou <[email protected]>
LeaVerou
reviewed
Jul 26, 2022
| should have a corresponding IDL attribute with the same name, | ||
| and the state between the two should be kept synchronized. | ||
| Carving out a synchronized IDL attribute with inconsistent naming | ||
| results in confusion, and should be avoided. |
There was a problem hiding this comment.
Suggested change
| results in confusion, and should be avoided. | |
| results in confusion, and should be avoided. | |
| <div class=example> | |
| The <{input}> element has <{input/value}> and <{input/checked}> attributes that hold the default state of the element. | |
| There are also {{HTMLInputElement/value}} and {{HTMLInputElement/checked}} that hold the *current* state of the element. | |
| The fact that these are not synchronized, and despite the same name, they actually hold different data, has caused authors a lot of confusion. | |
| </div> |
hober
added a commit
that referenced
this pull request
Apr 20, 2023
* Initial commit for #279. * Update index.bs Co-authored-by: Lea Verou <[email protected]> * Update index.bs Co-authored-by: Theresa O'Connor <[email protected]> * Update index.bs Co-authored-by: Theresa O'Connor <[email protected]> * Update index.bs Co-authored-by: Theresa O'Connor <[email protected]> * Added counterpattern examples. * Update index.bs Co-authored-by: Lea Verou <[email protected]> Co-authored-by: Lea Verou <[email protected]> Co-authored-by: Theresa O'Connor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There needs to be some extra details fleshed out.
Preview | Diff