Ink playground milestone 1

[radhe-zeeve]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1731

[PieWol]

Hey @radhe-zeeve thanks for the delivery!
Before I test the functionality and build it locally I would like to know if the branch you linked for documentation (version play) is the right branch to use to test all functionalities you added? Or would you recommend the main branch of the original repo as all your PR's from milestone 1 are already merged? Thanks for also linking the individual PR's.

[radhe-zeeve]

@PieWol Yes, most of the features mentioned are built in Zeeve-App:version_play branch and only version update through CI was managed in Zeeve-App:new_version

[PieWol]

@radhe-zeeve I'm having trouble following the readme both on ubuntu and macOS. Can you please make sure that the current way of setting this project up on a fresh machine works according to the readme? As in pull the repo freshly somewhere and start the build process from scratch.

On my arm mac it's failing on make generate due to

Compiling chalk-solve v0.83.0
error: failed to build archive: section too large

ink-playground/target/wasm32-unknown-unknown/release/build/psm-2f66b15b10c4600a/out/libpsm_s.a the table of contents is empty (no object file members in the library define global symbols)

error: could not compile `psm` due to previous error

and on ubuntu during make generate with

   Building [                           ] 8/290: autocfg, proc-macro2                                                                                                                                       
  error[E0635]: unknown feature `proc_macro_span_shrink`
    --> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.56/src/lib.rs:92:30
     |
  92 |     feature(proc_macro_span, proc_macro_span_shrink)
     |                              ^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                      
  error: could not compile `proc-macro2` (lib) due to 3 previous errors

Thank you.

[radhe-zeeve]

@PieWol On Mac it might not work due to ARM architecture.
As for Ubuntu 22.04 on x86_64 arch (2 Core 8 GB). It works

sudo apt update
sudo apt install make
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion
nvm install 18
npm i -g yarn
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
source "$HOME/.cargo/env"
sudo apt install gcc
sudo apt install libssl-dev pkg-config
https://github.com/Zeeve-App/ink-playground.git
cd ink-playground
git checkout version_play
make install
make generate
make build

[PieWol]

Hey @radhe-zeeve thanks for providing the instructions you expect to work. I have followed it as you said on ubuntu 22.04 and I'm still running into issues.

1. on make generate the wasm optimization fails.
2. make build fails afterwards.

I have included all relevant information to this in this pastebin . Please check it out and get back to me on how we can overcome this issue. Thank you.

[radhe-zeeve]

@PieWol
Please refer to the recording of the setup done on fresh Ubuntu instance: https://asciinema.org/a/636353
we can have a call if still not resolved.

[PieWol]

Thanks a lot @radhe-zeeve,
for some reason I was unable to compile it on the machine I first used. Now I just used another fresh instance and it worked like a charm. Hopefully I won't run into any more issues and get back to you once I completed the evaluation.

[PieWol]

Hey @radhe-zeeve ,
in the documentation deliverable you stated that

We will provide ... a basic tutorial that explains how a user can open and save a file

I can't seem to find that tutorial in the linked readme file. Where can I find this user focussed tutorial?

For the automated ink! version upgrade you wrote this github action, right? Why does it have no runs yet? Shouldn't it run everyday 6am GMT?

[PieWol]

Hey @radhe-zeeve ,
just checking in on you to see if there have been any updates you might be able to share.

[PieWol]

You have linked to the same PR for deliverable 1 and 3. The way I understand it this PR delivers the functionality promised for deliverable 3 with the github-action you put in place to check for new ink! versions and create a PR in case a new one is released. What I don't see right now is how it delivers the functionality of deliverable 1 .

We will add the ability to build the compiler environment if a compiler environment is not present with a specific version of Ink!

Can you please explain to me how this functionality is delivered and link me to the relevant code? Thank you :)

[radhe-zeeve]

Hey @radhe-zeeve , just checking in on you to see if there have been any updates you might be able to share.

Will be provide the doc and answers within couple of days

[radhe-zeeve]

@PieWol

• Updated documentation for testing check "Run Production service without dockerized image", "General usage", "Issues with running on remote server without HTTPS support" sections

• For the automated ink! version upgrade you wrote this github action, right? Why does it have no runs yet? Shouldn't it run everyday 6am GMT?

  • Answer: Since the repository is archived all the actions are disabled, I have pulled and changed the time to schedule the action and to execute it (https://github.com/Zeeve-App/ink-playground/actions/runs/7897895698/job/21554248329), the action did not create new PR because there was already a PR present in the repo with same name and open status ([auto-generated] add new ink version: 4.3.0 Zeeve-App/ink-playground#7).
• We will add the ability to build the compiler environment if a compiler environment is not present with a specific version of Ink! this was part of the version update where if the version is not present it will update the contract dependencies to new Ink version and add it to versions.json, then after testing the PR we can merge and also add docker file (in docker directory) with new version to have new Ink version support.

[PieWol]

Hey @radhe-zeeve thanks for your latest update!

I see how your github action updates the versions available for the users of the ink!-playground. Thats good and seems to be working as expected given the link to the upgrade PR and the github action output.

Thanks also for clarifying how this last deliverable that I was unsure about actually works. Now the way I understand is that you are preparing the ink!-playground code so that it will be able to interact with a dockerized compiler for the latest version once you have added the dockerized compiler as a dependancy for the repo. Is that correct? So "adding the possibility" translates to "preparing dependencies for a to be released dockerized compiler for the latest version"?

I would appreciate it if you could confirm my understand a final time. Thanks for your help so far!

[keeganquigley]

Thanks @radhe-zeeve @PieWol has accepted your milestone, here is his evaluation. I will hereby merge the delivery. In the meantime feel free to answer his remaining question above.

[github-actions]

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

[semuelle]

@radhe-zeeve, the postal address in your invoices doesn't match the one in your application. Could you modify one to match the other? Thanks!

[radhe-zeeve]

@semuelle sure, will update the address, upload and notify here.

[radhe-zeeve]

@semuelle the office address has been changed, the address in the invoice is the latest and canonical address. Do we have to change the application for this ?

[semuelle]

Do we have to change the application for this ?

Yes, please. Just submit a pull request with the changed address. Should be quickly approved.

[radhe-zeeve]

@semuelle Created a PR to update address in application: w3f/Grants-Program#2229

[radhe-zeeve]

@semuelle PR got merged, will Payment be settled within Feb 2024 ?

[semuelle]

@radhe-zeeve, I'm afraid this won't be settled today, so most likely next Friday.

[RouvenP]

hi @radhe-zeeve we sent the payment today