Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delivery report for milestone one of the third grant of OpenBrush(6 milestone) #515

Conversation

TtomaS7
Copy link
Contributor

@TtomaS7 TtomaS7 commented Jul 26, 2022

Preview

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#921

Copy link
Contributor

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TtomaS7 is there a specific reason for submitting M6 before M5?
Also, feel free to accept my edit suggestion since this should be a numeric value (and in this case, I think it should be 6).

deliveries/openbrush_follow_up_2-milestone_1.md Outdated Show resolved Hide resolved
@xgreenx
Copy link
Contributor

xgreenx commented Jul 27, 2022

In previous reports, we used "X milestone of the grant Y and Z milestone of the OpenBrush"=) But if it is okay to use just 6, we prefer that way=) I don't remember why we decided to go the previous way.

We added a small description in the delivery report, but I can provide more description.

Milestone five contains two points, which are changes in the ink!.

  • "Contribute to ink! with fixing of events" - We described our thoughts about the design of new events here and here. Seems ink! team okay with our ideas, but they want to finish that task by themself.
  • "Re-work the storage of contracts" - We had an active discussion in February and March about what new storage should look like. We finished the initial implementation of the storage in begin of May. After a discussion/review at the end of May, we decided to change some moments. We refactored the change. Next month ink! team were busy, so the next review took a long. Now we created a new fresh PR with the hope of finishing the review=)

All that already took a lot of time. We've started work on milestone six before the creation of the grant because of milestone five. Most of the points in milestone seven are also ready(because we work on it in parallel). Soon we will start working on milestone eight(and we need to create a new grant for that, but we can't because milestone six is not delivered cause of milestone five).

Milestone five depends on ink! team and related to ink!. It is partially related to OpenBrush, but we will refactor OpenBrush when the change is merged.

We only want to unblock our work and avoid cases where all milestones in the grant are already done before the creation of that grant. So it is why delivering milestone six without milestone five can make things simpler for us.

@takahser
Copy link
Contributor

@xgreenx thanks for elaborating on why you deliver M6 before M5 and updating the Milestone value in the doc.
We'll have a more detailed look at the delivery soon.

@ashlink11 ashlink11 self-assigned this Aug 3, 2022
@TtomaS7
Copy link
Contributor Author

TtomaS7 commented Aug 4, 2022

hello!
I have updated the invoice with new W3F address.

we faced up with it on Typechain grant, so now it’s updated everywhere :D

@ashlink11
Copy link
Contributor

Hi @TtomaS7, thank you for your delivery & I wanted to update you that I began work on this evaluation today.

@ashlink11
Copy link
Contributor

Good day @TtomaS7 & @xgreenx,

It's taken some time to deeply study your application, delivery & OpenBrush in depth, but thank you very much for the excellent article and WasmConf lecture. I'm planning to watch the Decoded lecture next & I'm almost ready to review the code. Very excited to! Thanks!

@ashlink11
Copy link
Contributor

ashlink11 commented Aug 12, 2022

Good day @TtomaS7 & @xgreenx,

I've completed my evaluation of your M6 and forwarded your invoice internally. Thank you very much!

By the way, @TtomaS7, I vaguely remember from your pitch call--I mentioned I could send you some resources but I cannot remember what these are. Now I am much more familiar with your project having completed an evaluation for you. I believe I'm much more able to help. I remember Green perhaps mentioning that there's no native inheritance in Rust but that you've done a workaround? Are you in need of any resources? By the way, excellent job with the Wasm Conference and great job managing the versioning of ink!!

@ashlink11 ashlink11 merged commit 2a2589e into w3f:master Aug 12, 2022
@TtomaS7
Copy link
Contributor Author

TtomaS7 commented Aug 15, 2022

Thank you for the review!

I don't remember too :D
I will think and return to you in Element.

@ashlink11
Copy link
Contributor

@TtomaS7 You're welcome! Btw, I remembered over the weekend! And so I just sent you a ping on Element. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants