Shivarthu Milestone 1 #535
Conversation
Shivarthu Milestone 1
|
@amiyatulu I took a look at your delivery, but I wasn't able to find the instructions to run and test your code. |
|
@takahser Thank you for reviewing. Docker compose is failing because non creation of .local folder. I have updated the docker-compose.yml file, please use the recent commit. I will soon give you the tutorial and instructions to test the app. |
@amiyatulu did you update the tutorial/instructions yet, so they reflects the latest changes? Please let me know when it's ready to test again. |
|
Hi, @takahser sorry for the delay. Please find the docs here: https://github.com/amiyatulu/shivarthu_frontend/blob/main/docs/Tutorial.md Please use the latest repository of shivarthu. https://github.com/amiyatulu/shivarthu |
|
@amiyatulu no problem, thanks for the update. I'm going to take another look soon. |
|
@amiyatulu thanks for your patience and sorry for the wait here - we have currently a rather large backlog and are a bit behind. I took another look, I added a few more comments regarding the deliveries 0b, 0c to my evaluation and I accepted 0d. Let me know if you have any questions. |
|
@takahser Thank you for the update. Documentation Feedback
Testing Guide Feedback
Waiting for your feedback. Please let me know what's need to be done further. |
There was a problem hiding this comment.
@amiyatulu thanks for your reply.
I am updating the logic of template to into a loose coupling pallet in the next version
Ok, that works for me. Please resolve it until the next delivery then.
I have updated some technical details that is not mentioned in the delivery doc, so made a new version.
The problem with this approach is, that it's difficult to track, which version is the current one. I'd suggest you integrate these changes into your original grant application doc by amending them. This should be easy to approve, especially if you just add features and/or technical details.
I will add more inline comments if you say, but in the schelling-game-shared and profile-validation
Okay. Yes, please add sufficient comments to help others understand your code, especially in case they want to reuse it for their own project(s).
What test guide do you need, about how to run the test?
Yes, for completeness it should contain test instructions (probably just cargo test).
|
@takahser Thank you for replying. I have updated the docs and removed most unused imports. Please have a look: https://github.com/amiyatulu/shivarthu |
|
@amiyatulu thanks for your patience and sorry for the delay. I checked it out again and tried to run the frontend. However, it's currently blank and showing a console error
The network requests look fine:
Also, the node is running and I didn't identify any issue when exploring it in neither of the two frontends:
Could you double-check if it works on your machine? |
|
@takahser Hi, frontend is running fine on my computer. Have you tried the latest commit? I have uploaded the frontend on vercel at https://shivarthuapp.vercel.app/ Updated tutorial: https://github.com/amiyatulu/shivarthu_frontend/blob/main/docs/Tutorial.md |
There was a problem hiding this comment.
@amiyatulu thanks for the update.
I pulled the latest changes and tried again - same result.
I'm on the following commits:
~/repos/shivarthu$ git log
commit 0535df8a374ea66b0411c4c23fe8a0f67937e8ea (HEAD -> main, origin/main, origin/HEAD)
Author: Amiya Behera <[email protected]>
Date: Fri Sep 23 16:56:32 2022 +0530
score game~/repos/shivarthu_frontend$ git log
commit 371fe81f75267bfd64d186e1f9582a52e76dcddb (HEAD -> main, origin/main, origin/HEAD)
Author: Amiya Behera <[email protected]>
Date: Thu Sep 29 13:20:57 2022 +0530
docs
|
@takahser Sorry it happened due to .env file which was in the gitignore. I have commented out the section that requires .env file. Please use the new commit. |
|
@amiyatulu sorry for the delay here, I didn't find time to take a look earlier. |
|
@amiyatulu I tried again and it's still not working. I tested your code on 2 machines (macOS and Ubuntu). |
|
@takahser Ok. This is my email id: amiyatulu at gmail.com Please let me know at what time and day you like to schedule a Google meet. |
|
@amiyatulu I've sent you some suggestions via email, please check. |
There was a problem hiding this comment.
@amiyatulu thanks for your time in yesterday's call and your explanations.
In the meanwhile, I was able to run and smoke-test your delivery and I decided to accept your delivery. However, there are a few things that you should improve for M2. I'm quoting directly from my evaluation:
As this is the first delivery, I'm now willing to accept it in the current state, but for M2 these issues should definitely be fixed. I'm referring to:
- more useful inline comments on the pallet code that can be used to generate documentation using rustdoc
- removal of the application doc that is out of sync with the original
- renaming of the template pallet to a more meaningful name
- fixing of warnings during the build & tests
I'm looking forward your M2 delivery that should incorporate these improvements.
Please let me know if you have any questions.
|
Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Note that it must only be used within the context of the delivered work, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#525 < please fill this in with the PR number of your application.