-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new_bls12_hash_function-milestone_2 #556
Conversation
Thanks for the new delivery @dishport. @drskalman did a great review of your first milestone and is now familiar with your function, so he's kindly offered to help with this delivery as well. @drskalman: @zhenfeizhang has worked on this implementation, so you probably want to refer to him for changes. Could you please fill in the checkmarks in the comment template above? You can already submit a separate invoice for this milestone with the previous one. |
@alxs, Who should fill in the invoice form for this milestone: me or @zhenfeizhang ? In other words, will you send the money directly to him or through me ? |
@dishport that would be you. You'll need to submit an invoice and payments should go to the same entity for one grant. |
@zhenfeizhang Please resolve zhenfeizhang/indifferentiable-hashing#1 so I am able to compile the code. thanx! |
Just pushed a fix. Please try again. |
@zhenfeizhang please resolve issue 2 and issue 3 |
@zhenfeizhang @dishport friendly reminder |
addressed both issues. Please take a look @alxs @drskalman |
ping on this -- the fixes are relatively small so can we please have a quick review? |
Hey @zhenfeizhang, we're on retreat this week so I kindly ask you for some (more) patience. @drskalman is also not officially in the grants team and only has limited time to review the delivery, but I pinged him about it. Thank you for your understanding. |
@drskalman, could you check the corrected code of @zhenfeizhang ? Thank you in advance. |
The tests still failing for me for BLS12-381. I commented on the issue: zhenfeizhang/indifferentiable-hashing#4 |
@dishport What is the status here? Could you take a look at these issues: https://github.com/zhenfeizhang/indifferentiable-hashing/issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(see message above)
I have resolved the bug in zhenfeizhang/indifferentiable-hashing#4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: #720
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to tell you that the milestone is finally approved. See #720 I will forward your invoice internally.
We noticed that this is the last milestone of your project, so what are the potential next steps? |
hi @drskalman we transferred the payment yesterday. |
Hi @RouvenP. I received. Thanks. |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#966