Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_bls12_hash_function-milestone_2 #556

Merged
merged 16 commits into from
Feb 1, 2023
Merged

Conversation

Dimitri-Koshelev
Copy link
Contributor

@Dimitri-Koshelev Dimitri-Koshelev commented Aug 30, 2022

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#966

@Dimitri-Koshelev Dimitri-Koshelev mentioned this pull request Aug 30, 2022
5 tasks
@alxs alxs self-assigned this Aug 31, 2022
@alxs
Copy link
Contributor

alxs commented Aug 31, 2022

Thanks for the new delivery @dishport. @drskalman did a great review of your first milestone and is now familiar with your function, so he's kindly offered to help with this delivery as well. @drskalman: @zhenfeizhang has worked on this implementation, so you probably want to refer to him for changes.

Could you please fill in the checkmarks in the comment template above? You can already submit a separate invoice for this milestone with the previous one.

deliveries/new_bls12_hash_function-milestone_2.md Outdated Show resolved Hide resolved
deliveries/new_bls12_hash_function-milestone_2.md Outdated Show resolved Hide resolved
deliveries/new_bls12_hash_function-milestone_2.md Outdated Show resolved Hide resolved
@Dimitri-Koshelev
Copy link
Contributor Author

Could you please fill in the checkmarks in the comment template above? You can already submit a separate invoice for this milestone with the previous one.

@alxs, Who should fill in the invoice form for this milestone: me or @zhenfeizhang ? In other words, will you send the money directly to him or through me ?

@alxs
Copy link
Contributor

alxs commented Aug 31, 2022

@dishport that would be you. You'll need to submit an invoice and payments should go to the same entity for one grant.

@alxs alxs requested a review from drskalman August 31, 2022 13:55
@drskalman
Copy link
Contributor

@zhenfeizhang Please resolve zhenfeizhang/indifferentiable-hashing#1 so I am able to compile the code. thanx!

@zhenfeizhang
Copy link
Contributor

@zhenfeizhang Please resolve zhenfeizhang/indifferentiable-hashing#1 so I am able to compile the code. thanx!

Just pushed a fix. Please try again.

@drskalman
Copy link
Contributor

@zhenfeizhang please resolve issue 2 and issue 3

@alxs alxs unassigned Noc2 Oct 19, 2022
@alxs
Copy link
Contributor

alxs commented Oct 26, 2022

@zhenfeizhang @dishport friendly reminder

@zhenfeizhang
Copy link
Contributor

addressed both issues. Please take a look @alxs @drskalman

@zhenfeizhang
Copy link
Contributor

ping on this -- the fixes are relatively small so can we please have a quick review?

@alxs
Copy link
Contributor

alxs commented Oct 31, 2022

Hey @zhenfeizhang, we're on retreat this week so I kindly ask you for some (more) patience. @drskalman is also not officially in the grants team and only has limited time to review the delivery, but I pinged him about it. Thank you for your understanding.

@drskalman
Copy link
Contributor

@Dimitri-Koshelev
Copy link
Contributor Author

Dimitri-Koshelev commented Dec 4, 2022

@zhenfeizhang zhenfeizhang/indifferentiable-hashing#4

@drskalman, could you check the corrected code of @zhenfeizhang ? Thank you in advance.

@drskalman
Copy link
Contributor

drskalman commented Dec 19, 2022

The tests still failing for me for BLS12-381. I commented on the issue: zhenfeizhang/indifferentiable-hashing#4

@Noc2 Noc2 assigned Noc2 and unassigned alxs Dec 29, 2022
@github-actions github-actions bot added the stale label Jan 13, 2023
@Noc2
Copy link
Collaborator

Noc2 commented Jan 27, 2023

@dishport What is the status here? Could you take a look at these issues: https://github.com/zhenfeizhang/indifferentiable-hashing/issues?

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see message above)

@zhenfeizhang
Copy link
Contributor

I have resolved the bug in zhenfeizhang/indifferentiable-hashing#4
An integrated version for arkworks 0.4.0 is available, see zhenfeizhang/indifferentiable-hashing#3 (comment)

Copy link
Contributor

@drskalman drskalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: #720

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to tell you that the milestone is finally approved. See #720 I will forward your invoice internally.

@Noc2 Noc2 merged commit e05420e into w3f:master Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

We noticed that this is the last milestone of your project, so what are the potential next steps?

While you can always apply for a follow-up grant, the grants program might not be the best tool for your future growth. Our main goal is to support research as well as early-stage technical projects. Below are a couple of other options in our ecosystem that might be better suited as the next step, depending on your goals:

Project with a Business Case/Token: Substrate Builders Program or VC Funding

Common Good Projects: Treasury Funding

Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.

@RouvenP
Copy link

RouvenP commented Feb 7, 2023

hi @drskalman we transferred the payment yesterday.

@Dimitri-Koshelev
Copy link
Contributor Author

hi @drskalman we transferred the payment yesterday.

Hi @RouvenP. I received. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants