Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP22: Update selectors and add the Result in the signature of methods #24

Merged
merged 7 commits into from
Aug 23, 2021

Conversation

xgreenx
Copy link
Contributor

@xgreenx xgreenx commented Jul 22, 2021

Update selectors according to PSP22 naming of the interface(previous selectors were generated for PSP20).
Added the Result in the signature of the methods, because based on a conversation in the issue we finalized, how revert will work and how we can return the data during the revert to the caller(and finalized how it can be implemented during cross contract calls).

@xgreenx xgreenx changed the title Update selector and add information how they generated Update selectors and add the Result in the signature of methods Aug 17, 2021
@xgreenx xgreenx changed the title Update selectors and add the Result in the signature of methods PSP22: Update selectors and add the Result in the signature of methods Aug 17, 2021
@0xMarkian
Copy link
Contributor

Hey @cmichi @Noc2 @athei!
I see that you approved changes on this PR. Let's have it merged if you are okay.
We would love to move the process forward :)

@xlc
Copy link
Contributor

xlc commented Aug 21, 2021

This format is really hard to read due to the ABI defs. It will be better if there is a at glance view of everything. Simply moving ABI to bottom of the file is also helpful.

@xgreenx
Copy link
Contributor Author

xgreenx commented Aug 21, 2021

This format is really hard to read due to the ABI defs. It will be better if there is a at glance view of everything. Simply moving ABI to bottom of the file is also helpful.

I agree with you, that it is hard to read. Do you have ideas of how to make it more readable?
As a solution, we can add an example of how types described in the defs section can be represented(implemented) in Rust.

@Noc2
Copy link
Collaborator

Noc2 commented Aug 23, 2021

Sounds good, I will merge the updates, but feel free to continue to improve readability.

@Noc2 Noc2 merged commit bb396a1 into w3f:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants