-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elastic Scaling #5591
Elastic Scaling #5591
Conversation
- grammar
@CrackTheCode016, asking for a preliminary review of the concept and broad mechanics ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments and suggestions, overall looking good. Some thoughts:
-
Since this isn't implemented yet, I would suggest we move this to Future Implementations
-
I am not sure we should have the challenges section, although I am open to keeping it if it facilitates understanding of the topic.
Co-authored-by: bader y <[email protected]>
Co-authored-by: bader y <[email protected]>
Co-authored-by: bader y <[email protected]>
@CrackTheCode016 I addressed your feedback. Let me know if it is ok with you ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would need to read more on core regions and how those will play a part, as I understand, that is the basis for how elastic scaling will take place (see here),
I think that detail should be added before it is merged. I'd like to dive a little deeper also into the technical implementations, and really ensure this is accurate before approving.
As a sidenote, having a dedicated page for coretime will accompany this page would be beneficial, as the two concepts go hand-in-hand. It would even be good to include a section on how the two relate, to clear up any confusion!
@DrW3RK @CrackTheCode016 let me know if this PR is good to go. On a high level is informative and I think it covers what elastic scaling will bring to Polkadot. In a second PR I could make better figures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I myself am not terrible familiar with the specifics of elastic scaling, it appears sensible to me and we can update it in the future.
backed, there was no previous parablock. | ||
|
||
With elastic scaling, it will take just 12 seconds (3-second block time) to include all four | ||
parablocks using two cores. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, if elastic scaling improves time in this manner, than naturally they would also have to pay more for this throughput ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more context on Elastic scaling and provided info on the phased rollout of its implementation.
The last section with figures and times will benefit from a review from the elastic scaling implementors.
Co-authored-by: Radha <[email protected]>
Co-authored-by: Radha <[email protected]>
Co-authored-by: Radha <[email protected]>
Co-authored-by: Radha <[email protected]>
Co-authored-by: Radha <[email protected]>
@DrW3RK who would you suggest to give a final review on this PR? |
@eskimor We are working on adding a high level Wiki doc on Elastic scaling. When you get time, could you please go over the content on this PR and provide feedback? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Add information about elastic scaling: how parachains will be able to reserve time on multiple cores and thus include multiple parablocks in a relay chain block at the same time, while producing parablocks < 6s
Some info: