Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Coretime Guides / Docs #5798

Merged
merged 8 commits into from
Apr 20, 2024
Merged

Improve Coretime Guides / Docs #5798

merged 8 commits into from
Apr 20, 2024

Conversation

CrackTheCode016
Copy link
Contributor

@CrackTheCode016 CrackTheCode016 commented Apr 18, 2024 •
edited
Loading

This PR addresses the following points from issue #5793

  • Add relevant cross-linking to other Wiki docs with definitions of keywords used
  •  Accessible explanations for new learners/new comers to the ecosystem
  •  Fetch on-chain constants/values wherever applicable
  • Provide more technical clarity around on the implications between on-demand versus bulk

@CrackTheCode016 CrackTheCode016 added the A1 - In Progress Not ready for review yet. label Apr 18, 2024
@CrackTheCode016 CrackTheCode016 self-assigned this Apr 18, 2024
@CrackTheCode016 CrackTheCode016 mentioned this pull request Apr 18, 2024
Open
6 tasks
@CrackTheCode016 CrackTheCode016 added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels Apr 19, 2024
DrW3RK
DrW3RK approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@DrW3RK DrW3RK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements! Thank you very much

@DrW3RK DrW3RK merged commit dcf5972 into master Apr 20, 2024
3 checks passed
@DrW3RK DrW3RK deleted the improve-coretime-docs branch April 20, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrW3RK DrW3RK DrW3RK approved these changes

Assignees

@CrackTheCode016 CrackTheCode016

Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CrackTheCode016 @DrW3RK