Fix FO3 / FNV / Skyrim LE files with special characters in the path corrupting when being packed #1600
Annotations
24 warnings
Test (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Test (ubuntu-latest)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Test (ubuntu-latest):
Wabbajack.Paths.IO/KnownFolders.cs#L16
Unreachable code detected
|
Test (ubuntu-latest):
Wabbajack.Downloaders.VerificationCache/VerificationCache.cs#L47
Nullability of reference types in return type of 'Task<(bool?, IDownloadState?)> VerificationCache.Get(IDownloadState archive)' doesn't match implicitly implemented member 'Task<(bool? IsValid, IDownloadState State)> IVerificationCache.Get(IDownloadState archive)'.
|
Test (ubuntu-latest):
Wabbajack.Downloaders.VerificationCache/NullCache.cs#L7
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
Test (ubuntu-latest):
Wabbajack.Downloaders.Mega/MegaToken.cs#L8
Non-nullable property 'Email' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
Test (ubuntu-latest):
Wabbajack.Downloaders.Mega/MegaToken.cs#L11
Non-nullable property 'Password' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
Test (ubuntu-latest):
Wabbajack.Networking.Steam/Client.cs#L122
'SteamUser.UpdateMachineAuthCallback' is obsolete: 'Steam no longer sends machine auth as of 2023, use SteamAuthentication.'
|
Test (ubuntu-latest):
Wabbajack.Networking.Steam/Client.cs#L92
'SteamUser.UpdateMachineAuthCallback' is obsolete: 'Steam no longer sends machine auth as of 2023, use SteamAuthentication.'
|
Test (ubuntu-latest):
Wabbajack.Networking.Steam/Client.cs#L148
'SteamUser.MachineAuthDetails' is obsolete: 'Steam no longer sends machine auth as of 2023, use SteamAuthentication.'
|
Test (ubuntu-latest):
Wabbajack.Networking.Steam/Client.cs#L148
'SteamUser.SendMachineAuthResponse(SteamUser.MachineAuthDetails)' is obsolete: 'Steam no longer sends machine auth as of 2023, use SteamAuthentication.'
|
Test (ubuntu-latest):
Wabbajack.Networking.Steam/Client.cs#L242
'SteamUser.LogOnDetails.SentryFileHash' is obsolete: 'Steam no longer accepts machine auth as of 2023, use SteamAuthentication.'
|
Test (windows-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Test (windows-latest)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Test (windows-latest):
Wabbajack.Paths.IO/KnownFolders.cs#L16
Unreachable code detected
|
Test (windows-latest):
Wabbajack.Downloaders.VerificationCache/VerificationCache.cs#L47
Nullability of reference types in return type of 'Task<(bool?, IDownloadState?)> VerificationCache.Get(IDownloadState archive)' doesn't match implicitly implemented member 'Task<(bool? IsValid, IDownloadState State)> IVerificationCache.Get(IDownloadState archive)'.
|
Test (windows-latest):
Wabbajack.Downloaders.VerificationCache/NullCache.cs#L7
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
Test (windows-latest):
Wabbajack.Downloaders.Mega/MegaToken.cs#L8
Non-nullable property 'Email' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
Test (windows-latest):
Wabbajack.Downloaders.Mega/MegaToken.cs#L11
Non-nullable property 'Password' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
Test (windows-latest):
Wabbajack.Hashing.PHash/TexConvImageLoader.cs#L158
The variable 'ex' is declared but never used
|
Test (windows-latest):
Wabbajack.Networking.Steam/Client.cs#L122
'SteamUser.UpdateMachineAuthCallback' is obsolete: 'Steam no longer sends machine auth as of 2023, use SteamAuthentication.'
|
Test (windows-latest):
Wabbajack.Networking.Steam/Client.cs#L92
'SteamUser.UpdateMachineAuthCallback' is obsolete: 'Steam no longer sends machine auth as of 2023, use SteamAuthentication.'
|
Test (windows-latest):
Wabbajack.Networking.Steam/Client.cs#L148
'SteamUser.MachineAuthDetails' is obsolete: 'Steam no longer sends machine auth as of 2023, use SteamAuthentication.'
|
Test (windows-latest):
Wabbajack.Networking.Steam/Client.cs#L148
'SteamUser.SendMachineAuthResponse(SteamUser.MachineAuthDetails)' is obsolete: 'Steam no longer sends machine auth as of 2023, use SteamAuthentication.'
|