Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More keys to control #129

Open
ryuheechul opened this issue Dec 7, 2018 · 7 comments
Open

More keys to control #129

ryuheechul opened this issue Dec 7, 2018 · 7 comments

Comments

@ryuheechul
Copy link

I would like to propose more keys to control dive

j to down
k to up
h and l to switch view
/ to start Filter files
esc to stop Filter files

for now and those are all inspired by vim keybindings

@wagoodman
Copy link
Owner

These were left out when making keybindings configurable, we can put this in the next release. Once it's in, you'd have to override the arrow keybindings in a local dive config (see the readme).

@rafi
Copy link

rafi commented Dec 24, 2018

... and q to quit :D

@wagoodman wagoodman added this to the UI Enhancements milestone Mar 25, 2019
@wagoodman wagoodman removed this from the UI Enhancements milestone Mar 25, 2019
@docwhat
Copy link

docwhat commented Aug 19, 2019

And the VIM page up/down as well:

keybinding:
  page-up: pgup,ctrl+u
  page-down: pgdn,ctrl+d

@abitrolly
Copy link
Contributor

abitrolly commented Dec 25, 2019

Looks like dive does not support bindings without modifiers.

keybinding:
        quit: q
could not find configured keybindings for: [keybinding.quit]

@docwhat
Copy link

docwhat commented Dec 25, 2019

Looks like dive does NOT support bindings without modifiers. ...

FTFY

Fixed!

@abitrolly

This comment has been minimized.

abitrolly added a commit to abitrolly/dive that referenced this issue Dec 26, 2019
wagoodman added a commit that referenced this issue Dec 26, 2019
Propagate error from parsing keybinding (#129)
@izeal
Copy link

izeal commented Dec 17, 2023

Hello, is there are way to bind up and down like in vim?

DeanAyalon pushed a commit to DeanAyalon/fork-dive that referenced this issue Oct 17, 2024
Bumps [docker/login-action](https://github.com/docker/login-action) from 2 to 3.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@v2...v3)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
joschi added a commit to joschi/dive that referenced this issue Nov 7, 2024
)

* Adding configurable keybindings for up/down arrows (`k` and `j` vim motions can be used as alternative to up/down arrows).
Thanks to @gwendolyngoetz for implementing this feature [Adding configurable keybindings for up/down arrows wagoodman#499](wagoodman#499)
* Add configurable keybindings for left/right arrows (`h` and `l` vim motions can be used as alternative to left/right arrows)
* Add `u` and `d` keys for page up/down alternatives (I didn't want to replace default `ctrl+u` toggle-unmodified-files keybinding so I used`u` and `d` like `Vimium` extension )
* Add `esc` key to close filtering (Implemented a new method by utilizing the existing toggle filter method, without touching its current behavior)

Refs wagoodman#129
Refs wagoodman#415
Refs wagoodman#499

Co-authored-by: Gwendolyn Goetz <[email protected]>
Co-authored-by: Mehmet Ümit Özden <[email protected]>
joschi added a commit to joschi/dive that referenced this issue Nov 7, 2024
)

* Adding configurable keybindings for up/down arrows (`k` and `j` vim motions can be used as alternative to up/down arrows).
Thanks to @gwendolyngoetz for implementing this feature [Adding configurable keybindings for up/down arrows wagoodman#499](wagoodman#499)
* Add configurable keybindings for left/right arrows (`h` and `l` vim motions can be used as alternative to left/right arrows)
* Add `u` and `d` keys for page up/down alternatives (I didn't want to replace default `ctrl+u` toggle-unmodified-files keybinding so I used`u` and `d` like `Vimium` extension )
* Add `esc` key to close filtering (Implemented a new method by utilizing the existing toggle filter method, without touching its current behavior)

Refs wagoodman#129
Refs wagoodman#415
Refs wagoodman#499

Co-authored-by: Gwendolyn Goetz <[email protected]>
Co-authored-by: Mehmet Ümit Özden <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do
Development

No branches or pull requests

6 participants