Reconcile history from image manifest and config #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filetree/tree.go
Outdated
| @@ -20,6 +20,7 @@ const ( | |||
| type FileTree struct { | |||
| Root *FileNode | |||
| Size int | |||
| FileSize int64 | |||
There was a problem hiding this comment.
Should we use uint64 here? The value can't be negative...
| fmt.Println(err) | ||
| os.Exit(1) | ||
| } | ||
| defer tarFile.Close() |
There was a problem hiding this comment.
Should the defer tarFile.Close() be immediately after os.Open()? Is there any situation where the code gets a file handle but then exits 1 before closing it?
There was a problem hiding this comment.
I'm not certain if there is a case where the file is open before exit is called, however, I still think this is the preferred way to go for a couple reasons:
- os.Exit cleans up file descriptors (in case the file was open but there was another error)
- since we're not guaranteed to have an open file we shouldn't attempt to close it until after we've checked it was opened with no error.
willmurphyscode
approved these changes
Oct 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling history from the docker API doesn't make sense for two reasons:
empty_contentbool, and inferring this from thecreated_byattribute is not accurate (sometimes a layer with content has acreated_byattribute that starts with anopstatement).Downside is that we have to calculate the layer size manually, but since we're already iterating across all contents, I don't see the harm. The upside is that we're not coupling to a docker API type?
This will require further cleanup.