-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use separate goreleaser config file to generate docker images based on alpine #245
Conversation
This is fantastic, thanks for the support! Building |
It is actually no effort for me. But I need you to setup a couple of secrets for me. Please add Alternatively, we can use GitHub's Registry (
Ok. |
GitHub Registry seems to be the right choice for security: keeping the dev image inaccessible from the "prod" docker hub registry. The extra login step is annoying, though not really a problem. I'm mentally stuck on:
|
Then, I need you to sign for the beta of the GitHub Registry (https://github.com/features/package-registry). Once it is enabled, the default GITHUB_TOKEN will have access to your own registry. Apart from that, this PR is ready to merge. However, note that merging this now will break the automatic publication of docker images. In order to enable it, Alternatively, it is possible to How do you release images now? Do you execute goreleaser on your workstation/laptop? |
I forgot to comment this. I believe that this note is because many things have been changing during the last months, and because the service has been 'free' during this period. Nevertheless, it will be out of beta next week; hence, each user will be able to define the complexity of the workflow within the limit of their budget. For public open source projects, the budget is 'maximum 20 parallel jobs'. No minutes per month limit. |
Today, I build and release images from my laptop. However, this weekend I'll start working on incorporating a pipeline that cuts releases on tag. Additionally I'll be adding steps that will test package installations for various platforms/OSs. This PR is a great starting point --I'll merge it and open another PR to accommodate the 0.9.1 changes I put in this morning. |
Close #243
In this PR,
.goreleaser.yml
is split (a new.goreleaser.docker.yml
file is created) andDockerfile
is modified to usealpine
as a base image (again).Since
dive
is not statically compiled any more, it needs to be built inside analpine
docker container (or on an Alpine host). To do so, scriptdocker.sh
is added. Temporal imagewagoodman/dive:dev
is built, which contains build dependencies. Then, goreleaser is executed inside the dev container.Note that images are not pushed yet. This is because I'd like to discuss whether to build
wagoodman/dive:dev
indocker.sh
or to add a GHA workflow to build it periodically (say weekly). Also, I wonder if thedocker run
command indocker.sh
should be merged into the makefile. I'll keep this PR as a draft for now.