Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package installation testing #250

Merged
merged 3 commits into from
Nov 20, 2019
Merged

Add package installation testing #250

merged 3 commits into from
Nov 20, 2019

Conversation

wagoodman
Copy link
Owner

This adds the ability to test the deb/rpm packages as well as do a smoke-ish like test for running on mac, windows, and linux. Any comments on approach/improvements are welcome!

@eine
Copy link

eine commented Nov 10, 2019

I am not sure about "This will run on merge to master, and for PRs with folks that also are part of the GHA beta". On the one hand, the condition is changed in this PR to on: [ push ]. On the other hand, even if contributors are not part of the GHA beta, when a PR is opened, tests should be executed. Moreover, if the contributor is part of the beta, tests will be executed twice: one as a push on the fork, and another time as a PR here.

Repository owner deleted a comment from kickinranch Nov 20, 2019
@wagoodman
Copy link
Owner Author

@1138-4eb quite right, when I tried this out it was in a private repo, which I believe why it was not running --comment removed.

@wagoodman wagoodman merged commit fe158e4 into master Nov 20, 2019
@wagoodman wagoodman deleted the add-package-tests branch November 20, 2019 22:56
@eine
Copy link

eine commented Nov 20, 2019

@wagoodman, IMHO you should keep pull_request and use if fields to avoid specific steps being executed, should you want to. Otherwise, you will need to blindly review PRs, or go to the forks to see the tests.

@wagoodman
Copy link
Owner Author

Ah I hadn't realized this is what you were pointing out. I'll go back and add this in, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants