Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting source in config file (fixes #267) #283

Merged
merged 2 commits into from
Mar 8, 2020
Merged

Allow setting source in config file (fixes #267) #283

merged 2 commits into from
Mar 8, 2020

Conversation

abitrolly
Copy link
Contributor

@abitrolly abitrolly commented Feb 22, 2020 •
edited
Loading 

✗ cat dive.yaml 
source: podman
✗ dive --config dive.yaml 633
Using config file: dive.yaml
Image Source: podman://633

@wagoodman wagoodman linked an issue Feb 23, 2020 that may be closed by this pull request
Can't set podman in config file #267
Closed
wagoodman
wagoodman approved these changes Mar 8, 2020
View reviewed changes
Copy link
Owner

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@wagoodman wagoodman merged commit f9e29dc into wagoodman:master Mar 8, 2020
@abitrolly abitrolly deleted the sourceconfig branch March 8, 2020 19:15
@EdJoPaTo EdJoPaTo mentioned this pull request May 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't set podman in config file
2 participants
@abitrolly @wagoodman