Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require golang 1.10+ (closes #278) #289

Merged
merged 2 commits into from
May 13, 2020
Merged

Conversation

abitrolly
Copy link
Contributor

@abitrolly abitrolly commented Mar 23, 2020

Because strings.Builder was added in 1.10 - https://www.calhoun.io/concatenating-and-building-strings-in-go/

✗ sudo snap refresh go --channel 1.9/stable --classic
go (1.9/stable) 1.9.7 from Michael Hudson-Doyle (mwhudson) refreshed
✗ go version
go version go1.9.7 linux/amd64
✗ GO111MODULE=auto go build
# github.com/wagoodman/dive/runtime/ci
runtime/ci/evaluator.go:137:9: undefined: strings.Builder

@wagoodman wagoodman merged commit 8fe31e8 into wagoodman:master May 13, 2020
@abitrolly abitrolly deleted the patch-1 branch May 13, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants