Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ioutil deprecation #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidhay1969
Copy link

Updated: -

- bouncer/licenses/classifier.go
- bouncer/licenses/find.go:20
- bouncer/finder.go

to remove deprecated ioutil library

Signed-off-by: Dave Hay <[email protected]>

To resolve "can't load fmt" error, seen when running: -

.tmp/bin/golangci-lint --version

etc.

Signed-off-by: Dave Hay <[email protected]>
Updated: -

- bouncer/licenses/classifier.go
- bouncer/licenses/find.go:20
- bouncer/finder.go

to remove deprecated ioutil library

Signed-off-by: Dave Hay <[email protected]>
@davidhay1969
Copy link
Author

bouncer/licenses/classifier.go changes

bouncer/licenses/classifier.go:19:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^

bouncer/licenses/find.go changes

bouncer/licenses/find.go:20:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^

bouncer/finder.go changes

bouncer/finder.go:7:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^

@davidhay1969
Copy link
Author

Hey @wagoodman thanks for the review/approval - however I note that one of the CI build jobs failed with: -

...

Allow Rules: [BSD.* MIT.* Apache.* MPL.*]
Unallowable license (OpenSSL) from "crypto/internal/boring"
failed validation
make: *** [Makefile:98: ci-plugs-out-test] Error 1
Error: Process completed with exit code 2.
...

and that you've added crypto/internal/boring to .bouncer.yaml

Is there a way to rerun the CI for this PR and see whether that test now passes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants