Fix Safari JS error accessing window.external
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` [Error] TypeError: undefined is not an Object. (evaluating ''msTrackingProtectionEnabled' in window.external') (anonymous function) (tracker.js:3:114) Global Code (tracker.js:137) ``` https://developer.mozilla.org/en-US/docs/Web/API/Window/external#browser_compatibility
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 15 15
Lines 732 732
Branches 137 137
=======================================
Hits 643 643
Misses 54 54
Partials 35 35 ☔ View full report in Codecov by Sentry. |
Stormheg
reviewed
Dec 13, 2023
Comment on lines
3
to
4
| if (window.doNotTrack || navigator.doNotTrack || navigator.msDoNotTrack || (window.external || {}).msTrackingProtectionEnabled) { | ||
| if (window.doNotTrack == '1' || navigator.doNotTrack == 'yes' || navigator.doNotTrack == '1' || navigator.msDoNotTrack == '1' || 'msTrackingProtectionEnabled' in window.external && window.external.msTrackingProtectionEnabled()) { |
There was a problem hiding this comment.
I think we are good dropping the entire window.external.msTrackingProtectionEnabled check.
This appears to be only supported in Internet Explorer 9 if this docs page I found is accurate: https://learn.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/platform-apis/gg593071(v=vs.85)
We don't support IE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tracker.jscode attempts to honour the "Do Not Track" browser flag, but it's using a deprecated API, which has been removed from Safari. Currently it fails with this message: