Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
window.wagtailAbTesting
in-page script totracker.js
. This will allow for a better CSP control as we move away from in-line scripts.In addition, the logic to get the parameters necessary for tracking has been offloaded from the script to the template tag function.
Finally, the data is now passed to
tracker.js
via thejson_script
built-in Django template filter, which takes care of JS escaping and is compatible with a strict CSP.