-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile and docker-compose.yml #45
Conversation
Two things:
If I tweak
|
|
Thanks! I'll get S3 in there and then it should be ready to merge. Do you
know if there are plans to add Travis (or another CI)? We could also
include a smoke test for the docker image.
|
We definitely did not get so far as to have a discussion regarding CI, but I think that it is an excellent idea, given that we have multiple contributors. |
5e32b2b
to
40ebcc9
Compare
@daaray I could not get S3 working with boto3, but this configuration seems to work. Might have been because I'm relying on |
Yes, I did utilize boto3, per the blog post I derived the material from: https://wagtail.io/blog/amazon-s3-for-media-files/ |
This appears to be the issue: jschneier/django-storages#268 Given this and the number of other |
98a8c21
to
d0e8940
Compare
Tested latest (pre Travis commits):
🚢 when you are happy with the Travis config. |
205c0a9
to
478a274
Compare
…gurable via the environment), Docker instructions, and a .travis.yml to build/test the Docker image.
478a274
to
6652c42
Compare
Hey there! I just came across this issue and experienced the same killed by signal 11 when using django-storages in Docker. I've used python:3.6-alpine and then retried it with python:3.6-jessie and suddenly it works. Don't know why, but better to use boto3 than boto. Just fyi :) |
Alpine linux doesn't have glibc so the Python implementation is probably linked against musl instead. I guess that has something to do with the crash you're getting. It looks like a lot of Python projects run into an issue with musl's small default stack size (80kb) leading to segfaults. |
Yep, we've seen issues with Alpine Linux before: wagtail/wagtail#3438. The conclusion I came to then was that the default system config was too resource-constrained for us to sensibly support. |
To do:
readme.md
) to production settings file.travis.yml
for testing Docker image build (can be expanded later to run unit tests, if any)