Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 20 & Upgrade npm packages (#463) Fix #462 #463

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

lb-
Copy link
Member

@lb- lb- commented Nov 11, 2023

  • Update all pre-commit configs to be in sync with package.json updates
  • stylelint-config-prettier is no longer required as of Stylelint15
  • Turn off some new rules that are not required in the existing code
  • Update Eslint ecmaversion to something closer to real world browser support
  • Add fix:css npm script for easier Stylelint updates
  • Add nvmrc for easier FNM/NVM usage
  • Closes Update Node/NPM libraries (Node 20) #462

@lb- lb- added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 11, 2023
@lb- lb- force-pushed the maintenance/upgrade-node-packages branch from b7dd751 to 55f811c Compare November 12, 2023 04:58
- Update all pre-commit configs to be in sync with package.json updates
- `stylelint-config-prettier` is no longer required as of Stylelint15
- Turn off some new rules that are not required in the existing code
- Update Eslint ecmaversion to something closer to real world browser support
- Add `fix:css` npm script for easier Stylelint updates
- Add nvmrc for easier FNM/NVM usage
- Closes wagtail#462
@lb- lb- force-pushed the maintenance/upgrade-node-packages branch from 55f811c to 122d0b7 Compare December 5, 2023 09:54
@lb-
Copy link
Member Author

lb- commented Dec 5, 2023

Updated with a few recent package updates since this was created.

Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking solid, thank you @lb-!

@thibaudcolas thibaudcolas changed the title Upgrade to Node 20 & Upgrade npm packages Upgrade to Node 20 & Upgrade npm packages (#463) Fix #462 Dec 16, 2023
@thibaudcolas thibaudcolas merged commit 7265840 into wagtail:main Dec 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Node/NPM libraries (Node 20)
2 participants