Upgrade to Django 5.0 + add FormSubmissionsPanel #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudcolas
force-pushed
the
django-5-upgrade
branch
from
ab03287
to
1aa968c
Compare
4 tasks
zerolab
reviewed
Jan 5, 2024
| @@ -1,4 +1,4 @@ | |||
| FROM python:3.9-slim | |||
| dwFROM python:3.12-slim | |||
There was a problem hiding this comment.
Suggested change
| dwFROM python:3.12-slim | |
| FROM python:3.12-slim |
zerolab
reviewed
Jan 5, 2024
| @@ -33,7 +33,7 @@ RUN set -ex \ | |||
| zlib1g-dev \ | |||
| " \ | |||
| && apt-get update && apt-get install -y --no-install-recommends $BUILD_DEPS \ | |||
| && python3.9 -m venv ${VIRTUAL_ENV} \ | |||
| && python3.12 -m venv ${VIRTUAL_ENV} \ | |||
| && pip install -U pip \ | |||
| && pip install --no-cache-dir -r /requirements/production.txt \ | |||
There was a problem hiding this comment.
nitpick: would be good to change these to be python3.12 -m pip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the only change strictly needed is the one to the requirements’ definition, but I took the time to also update Django settings for v5.0 based on what was deprecated / removed. And updating all the documentation URLs so they’re more "evergreen".
I also added
FormSubmissionsPanelto ourFormPage(see wagtail/wagtail#11405).