Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wagtail 6 to testing matrix #77

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Add Wagtail 6 to testing matrix #77

merged 2 commits into from
Apr 24, 2024

Conversation

mgax
Copy link
Member

@mgax mgax commented Apr 23, 2024

The default testing matrix only includes Wagtail 5.2. I wonder if this should be testing against dev versions of Wagtail too? It would help surface compatibility issues sooner.

Here's a successful test run. It's based off the #76 branch.

@chris48s
Copy link
Collaborator

chris48s commented Apr 23, 2024

Thanks.
The cookiecutter does already give you a nightly build that runs tests against whatever is on main in the wagtail repo
https://github.com/wagtail/cookiecutter-wagtail-package/blob/main/%7B%7B%20cookiecutter.__project_name_kebab%20%7D%7D/.github/workflows/nightly.yml
This helps surface possible compatibility problems, but it means it isn't a requirement for pushes/PRs.

@chris48s
Copy link
Collaborator

While we're doing this, could you also add the wagtail 6 framework classifier in pyproject.toml. Aside from that, looks good.

@mgax
Copy link
Member Author

mgax commented Apr 24, 2024

While we're doing this, could you also add the wagtail 6 framework classifier in pyproject.toml. Aside from that, looks good.

Ah, good catch, thanks! I've added the classifier.

@chris48s chris48s merged commit 4c3cd0b into wagtail:main Apr 24, 2024
4 checks passed
@mgax mgax deleted the wagtail-6.0 branch April 24, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants