Image support webapp #67
Conversation
| def get_image_title(self, image): | ||
| """See base class.""" | ||
|
|
||
| return image["image"]["name"].replace("-", " ") |
There was a problem hiding this comment.
Is it maybe nice to also remove the extension from the name here? (I'm assuming it's there because of the get_image_mimetype method)
| class DummyChannelSerializer(serializers.ModelSerializer): | ||
| """DummyChannel serializer""" | ||
| class ImageListSerializer(serializers.ListSerializer): | ||
| def get_value(self, dictionnary): |
There was a problem hiding this comment.
dictionary instead of dictionnary if I'm nitpicking ;-)
| def get_image_content(self, image): | ||
| """See base class.""" | ||
|
|
||
| return Image.objects.get(id=image["id"]).image |
There was a problem hiding this comment.
Won't this give a problem with the Delete view you also added below? It seems to only delete the image, but this view might raise an Image.DoesNotExist then? Or is it never called anymore?
There was a problem hiding this comment.
@lucasmoeskops I tried hard but I can't get your point.
Is it the DeleteImageView that you are talking about?
If so, what problem might occur and when?
There was a problem hiding this comment.
Yes, in the DeleteImageView, the only thing that seems to be done is to delete the specified Image instance. But can the image not still be used in an existing message, so that this code will raise an error when trying to do .get(id=image["id"])?
I mean basically, the image seems to be deleted, but the message seems to still exist. Trying to reproduce it, but having some issues with csrf token validation at the moment interestingly :-(
There was a problem hiding this comment.
I expect that the user will click "Save changes" in which case the image will no longer be in the message. If we send an update, the id of the message deleted won't be in the update so I think we should not have an error there.
I get sometimes a csrf token error but when I refresh or close and reopen the tab it works fine. Maybe there is something else too.
There was a problem hiding this comment.
You are right! It is no issue because a different message is sent. All right :-) Then I'll merge the request!
This PR adds image support to the webapp.
I also renamed the model
DummyChanneltoChanneland refactored/lint the js code; that's why it comes with so many additions and deletions.