Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update rln-js #225

Merged
merged 12 commits into from
Apr 27, 2023
Merged

chore: update rln-js #225

merged 12 commits into from
Apr 27, 2023

Conversation

weboko
Copy link
Contributor

@weboko weboko commented Apr 12, 2023 •
edited
Loading

What's done

  • improved structure of the example;
  • used new API from RLNContract;
  • bump @waku packages versions;

Resolves: waku-org/js-rln#29
Relative: #220

Blocked by waku-org/js-rln#55 and waku-org/js-rln#56

@weboko weboko requested a review from fryorcraken April 13, 2023 00:12
weboko
weboko commented Apr 13, 2023
View reviewed changes
examples/rln-js/index.js Outdated Show resolved Hide resolved
@weboko weboko mentioned this pull request Apr 14, 2023
Closed
12 tasks
danisharora099
danisharora099 approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commits LGTM. (havent checked functionality on UI)

fryorcraken
fryorcraken reviewed Apr 19, 2023
View reviewed changes
examples/rln-js/index.html Outdated Show resolved Hide resolved
examples/rln-js/index.js Show resolved Hide resolved
@weboko weboko requested a review from fryorcraken April 19, 2023 19:30
@weboko weboko mentioned this pull request Apr 25, 2023
Merged
@weboko weboko mentioned this pull request Apr 25, 2023
Open
@weboko weboko merged commit ada5250 into master Apr 27, 2023
@weboko weboko deleted the weboko/rln-js branch April 27, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-ramos richard-ramos richard-ramos left review comments

@rymnc rymnc rymnc left review comments

@danisharora099 danisharora099 danisharora099 approved these changes

@fryorcraken fryorcraken fryorcraken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contract handling helper
5 participants
@weboko @richard-ramos @danisharora099 @rymnc @fryorcraken