Feat/peer manager #596
Merged
Feat/peer manager #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (50)
|
|
|
||
| // TODO: Move all the protocol IDs to a common location. | ||
| // WakuRelayIDv200 is protocol ID for Waku v2 relay protocol | ||
| const WakuRelayIDv200 = protocol.ID("/vac/waku/relay/2.0.0") |
There was a problem hiding this comment.
this constant can be obtained from relay package
There was a problem hiding this comment.
If i do that, it was causing some circular import issue.
I think we will have to move all protocol constants to a common file so that they can be imported wherever we want.
| if inRelayPeers.Len() > int(pm.InRelayPeersTarget) { | ||
| //Start disconnecting peers, based on what? | ||
| //For now, just disconnect most recently connected peers | ||
| //TODO: Need to have more intelligent way of doing this, maybe peer scores. |
There was a problem hiding this comment.
I like the idea of using peer score for choosing which peer to remove!
Using peerstore's supportedProtocols method Co-authored-by: richΛrd <[email protected]>
Review comment, use context to pause connectivity loop during node shutdown. Co-authored-by: richΛrd <[email protected]>
richard-ramos
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce peer manager as per #621
Tested pruning of incoming relay peer connections based on configuration.
Tested outRelay Peers limit based on configuration.
Not sure if this will impact service peer connectivity, since that has not yet been tested.
If so, then will implement service slots next which should take care of that.