feat: implement relay connectivity loop #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Jenkins BuildsClick to see older builds (18)
|
chaitanyaprem
force-pushed
the
feat/relay-conn-loop
branch
from
57fdd45
to
d17ce1f
Compare
richard-ramos
changed the title
richard-ramos
approved these changes
Aug 14, 2023
| @@ -73,40 +94,112 @@ func (pm *PeerManager) connectivityLoop(ctx context.Context) { | |||
| case <-ctx.Done(): | |||
| return | |||
| case <-t.C: | |||
| pm.pruneInRelayConns() | |||
| pm.connectToRelayPeers() | |||
There was a problem hiding this comment.
In line 92, we probably need to add a defer t.Stop()
| } else if direction == network.DirOutbound { | ||
| outPeers = append(outPeers, p) | ||
| } | ||
| } |
There was a problem hiding this comment.
Is it worth to add a pm.logger.Error line indicating the cause of error while attempting to retrieve the direction?
waku/v2/peermanager/peer_manager.go
Outdated
| } | ||
| pm.logger.Info("Successfully disconnected connection towards peer", |
There was a problem hiding this comment.
It probably makes sense to either remove this log line, or change it into Debug, since this is what we expect should happen most of the time, it will probably introduce too much noise in the logs
Suggested change
| pm.logger.Info("Successfully disconnected connection towards peer", | |
| pm.logger.Info("Successfully disconnected connection towards peer", |
Co-authored-by: richΛrd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented a relay connectivity loop similar to https://github.com/waku-org/nwaku/pull/1482/files.
Changes
Tests
All unit tests passed.