Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rln-relay): flush_interval incorrectly set #671

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

richard-ramos
Copy link
Member

Description

See waku-org/nwaku#1933 for motivation behind this change

Changes

  • Updates go-zerokit-rln to a version that uses flush_every_ms instead of flush_interval
  • Uses a time.Duration to set the interval instead of an uint

@status-im-auto
Copy link

status-im-auto commented Aug 23, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ df589ec #1 2023-08-23 15:36:02 ~1 min linux 📦deb
✔️ df589ec #1 2023-08-23 15:36:48 ~2 min nix-flake 📄log
✔️ df589ec #1 2023-08-23 15:37:44 ~2 min tests 📄log
✔️ df589ec #1 2023-08-23 15:37:57 ~3 min tests 📄log
✔️ df589ec #1 2023-08-23 15:38:38 ~3 min android 📦tgz
✔️ df589ec #1 2023-08-23 15:39:13 ~4 min ios 📦tgz

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit 7e36f91 into master Aug 24, 2023
12 checks passed
@richard-ramos richard-ramos deleted the fix/flush_interval branch August 24, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants