Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rln-relay): use the only key from keystore if only 1 exists #708

Merged
merged 1 commit into from
Sep 8, 2023
Merged

chore(rln-relay): use the only key from keystore if only 1 exists #708

merged 1 commit into from
Sep 8, 2023

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Sep 4, 2023 •
edited
Loading

Description

See waku-org/nwaku#1984 for reasoning behind this change

Changes

  • Created a custom flag type for optional uint values with no default 0 value
  • Load a credential automagically if there is only a single credential available on keystore
  • Test chat2

Issue

Part of #655

@status-im-auto
Copy link

status-im-auto commented Sep 4, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (42)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3457b27 #1 2023-09-04 21:49:24 ~1 min linux 📦deb
✔️ 3457b27 #1 2023-09-04 21:50:06 ~2 min nix-flake 📄log
✔️ 3457b27 #1 2023-09-04 21:51:07 ~3 min tests 📄log
✔️ 3457b27 #1 2023-09-04 21:51:14 ~3 min tests 📄log
✔️ 3457b27 #1 2023-09-04 21:51:50 ~3 min android 📦tgz
✔️ 3457b27 #1 2023-09-04 21:52:47 ~4 min ios 📦tgz
✔️ 793689e #2 2023-09-05 20:05:47 ~32 sec linux 📦deb
✔️ 793689e #2 2023-09-05 20:06:02 ~45 sec tests 📄log
✔️ 793689e #2 2023-09-05 20:07:04 ~1 min tests 📄log
✔️ 793689e #2 2023-09-05 20:07:09 ~1 min nix-flake 📄log
✔️ 793689e #2 2023-09-05 20:08:57 ~3 min android 📦tgz
✔️ 793689e #2 2023-09-05 20:11:47 ~6 min ios 📦tgz
✔️ a7bceaf #3 2023-09-05 20:17:21 ~30 sec linux 📦deb
✔️ a7bceaf #3 2023-09-05 20:18:47 ~1 min nix-flake 📄log
✔️ a7bceaf #3 2023-09-05 20:19:43 ~2 min tests 📄log
✔️ a7bceaf #3 2023-09-05 20:19:55 ~3 min tests 📄log
✔️ a7bceaf #3 2023-09-05 20:21:48 ~4 min android 📦tgz
✔️ a7bceaf #3 2023-09-05 20:22:45 ~5 min ios 📦tgz
✔️ adacf87 #4 2023-09-05 20:21:27 ~36 sec linux 📦deb
✔️ adacf87 #4 2023-09-05 20:21:35 ~44 sec tests 📄log
✔️ adacf87 #4 2023-09-05 20:22:43 ~1 min nix-flake 📄log
✔️ adacf87 #4 2023-09-05 20:23:40 ~2 min tests 📄log
✔️ adacf87 #4 2023-09-05 20:24:57 ~4 min ios 📦tgz
✔️ adacf87 #4 2023-09-05 20:24:59 ~3 min android 📦tgz
✔️ 8f7e7af #5 2023-09-08 15:37:42 ~1 min tests 📄log
✔️ 8f7e7af #5 2023-09-08 15:38:03 ~1 min linux 📦deb
✔️ 8f7e7af #5 2023-09-08 15:38:13 ~1 min tests 📄log
✔️ 8f7e7af #5 2023-09-08 15:38:31 ~2 min nix-flake 📄log
✔️ 8f7e7af #5 2023-09-08 15:39:52 ~3 min android 📦tgz
✔️ 8f7e7af #5 2023-09-08 15:40:55 ~4 min ios 📦tgz
✔️ 9924cd0 #6 2023-09-08 15:44:10 ~56 sec linux 📦deb
✔️ 9924cd0 #6 2023-09-08 15:44:11 ~53 sec tests 📄log
✔️ 9924cd0 #6 2023-09-08 15:45:05 ~1 min tests 📄log
✔️ 9924cd0 #6 2023-09-08 15:45:09 ~1 min nix-flake 📄log
✔️ 9924cd0 #6 2023-09-08 15:46:30 ~3 min android 📦tgz
✔️ 9924cd0 #6 2023-09-08 15:46:49 ~3 min ios 📦tgz
✔️ a8099b0 #7 2023-09-08 15:48:03 ~50 sec tests 📄log
✔️ a8099b0 #7 2023-09-08 15:48:03 ~54 sec linux 📦deb
✔️ a8099b0 #7 2023-09-08 15:48:57 ~1 min tests 📄log
✔️ a8099b0 #7 2023-09-08 15:49:04 ~1 min nix-flake 📄log
✔️ a8099b0 #7 2023-09-08 15:50:18 ~3 min android 📦tgz
✔️ a8099b0 #7 2023-09-08 15:50:42 ~3 min ios 📦tgz
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7346e6d #8 2023-09-08 15:51:32 ~49 sec tests 📄log
✔️ 7346e6d #8 2023-09-08 15:51:35 ~56 sec linux 📦deb
✔️ 7346e6d #8 2023-09-08 15:52:33 ~1 min nix-flake 📄log
✔️ 7346e6d #8 2023-09-08 15:52:47 ~2 min tests 📄log
✔️ 7346e6d #8 2023-09-08 15:53:37 ~3 min android 📦tgz
✔️ 7346e6d #8 2023-09-08 15:55:30 ~4 min ios 📦tgz
✔️ 22baa0b #9 2023-09-08 15:57:00 ~51 sec linux 📦deb
✔️ 22baa0b #9 2023-09-08 15:57:01 ~52 sec tests 📄log
✔️ 22baa0b #9 2023-09-08 15:57:55 ~1 min tests 📄log
✔️ 22baa0b #9 2023-09-08 15:58:07 ~1 min nix-flake 📄log
✔️ 22baa0b #9 2023-09-08 15:59:07 ~3 min android 📦tgz
✔️ 22baa0b #9 2023-09-08 16:00:05 ~3 min ios 📦tgz

@richard-ramos richard-ramos force-pushed the optional-membership-index branch 3 times, most recently from a7bceaf to adacf87 Compare September 5, 2023 20:20
@richard-ramos richard-ramos marked this pull request as ready for review September 5, 2023 20:21
chaitanyaprem
chaitanyaprem approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos force-pushed the optional-membership-index branch 4 times, most recently from a8099b0 to 7346e6d Compare September 8, 2023 15:50
@richard-ramos richard-ramos merged commit 8783cd2 into master Sep 8, 2023
2 checks passed
@richard-ramos richard-ramos deleted the optional-membership-index branch September 8, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@harsh-98 harsh-98 Awaiting requested review from harsh-98

Assignees
No one assigned
Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-ramos @status-im-auto @chaitanyaprem