Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: append RLN proofs when posting messages in REST/RPC #718

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Sep 7, 2023

Description

If RLN is enabled, proofs will be appended automatically to the messages sent while using the REST or RPC servers.

Changes

  • Append RLN Proofs to messages
  • Validate topic subscription before posting a message
  • Added some comments and fixed code climate issues for some of the files involved in this change

Issue

part of #655

@status-im-auto
Copy link

status-im-auto commented Sep 7, 2023

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6f58393 #1 2023-09-07 18:06:26 ~2 min nix-flake 📄log
✔️ 6f58393 #1 2023-09-07 18:06:42 ~2 min linux 📦deb
✔️ 6f58393 #1 2023-09-07 18:07:09 ~2 min tests 📄log
✔️ 6f58393 #1 2023-09-07 18:07:10 ~2 min tests 📄log
✔️ 6f58393 #1 2023-09-07 18:08:27 ~4 min android 📦tgz
✔️ 6f58393 #1 2023-09-07 18:09:46 ~5 min ios 📦tgz
✔️ b5294bd #2 2023-09-07 18:09:42 ~1 min nix-flake 📄log
✔️ b5294bd #2 2023-09-07 18:10:07 ~2 min linux 📦deb
✔️ b5294bd #2 2023-09-07 18:10:40 ~2 min tests 📄log
✔️ b5294bd #2 2023-09-07 18:10:41 ~2 min tests 📄log
✔️ b5294bd #2 2023-09-07 18:11:33 ~3 min android 📦tgz
✔️ b5294bd #2 2023-09-07 18:13:23 ~5 min ios 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 136ebcc #3 2023-09-08 06:20:28 ~2 min nix-flake 📄log
✔️ 136ebcc #3 2023-09-08 06:20:50 ~2 min linux 📦deb
✔️ 136ebcc #3 2023-09-08 06:21:29 ~3 min tests 📄log
✔️ 136ebcc #3 2023-09-08 06:21:31 ~3 min tests 📄log
✔️ 136ebcc #3 2023-09-08 06:22:27 ~4 min android 📦tgz
✔️ 136ebcc #3 2023-09-08 06:23:34 ~5 min ios 📦tgz
✔️ 1490f21 #4 2023-09-08 18:38:04 ~54 sec linux 📦deb
✔️ 1490f21 #4 2023-09-08 18:38:29 ~1 min tests 📄log
✔️ 1490f21 #4 2023-09-08 18:39:04 ~1 min nix-flake 📄log
✔️ 1490f21 #4 2023-09-08 18:39:07 ~1 min tests 📄log
✔️ 1490f21 #4 2023-09-08 18:40:58 ~3 min android 📦tgz
✔️ 1490f21 #4 2023-09-08 18:41:53 ~4 min ios 📦tgz

waku/v2/node/wakunode2_no_rln.go Outdated Show resolved Hide resolved
cmd/waku/rest/relay.go Outdated Show resolved Hide resolved
cmd/waku/rpc/relay.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit cc28267 into master Sep 8, 2023
2 checks passed
@richard-ramos richard-ramos deleted the rln-proof branch September 8, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants