Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how msgIdProvider are generated in Waku Relay #1179

Closed
fryorcraken opened this issue Feb 13, 2023 · 1 comment · Fixed by #1322
Closed

Investigate how msgIdProvider are generated in Waku Relay #1179

fryorcraken opened this issue Feb 13, 2023 · 1 comment · Fixed by #1322
Assignees

Comments

@fryorcraken
Copy link
Collaborator

This is a investigation request

Problem

See waku-org/nwaku#1556

Proposed Solutions

Understand what is done in js-waku and ensure it's aligned with go-waku and nwaku.

Notes

The behaviour is most likely inherited from @ChainSafe/libp2p-gossipsub and it's unclear whether we can override it.

@weboko weboko self-assigned this May 2, 2023
@weboko
Copy link
Collaborator

weboko commented May 2, 2023

msgId configuration is defined here and can be influenced by msgIdFn options passed to GossipSub class.

If not passed depending on Sign policy it will use one of pre-defined implementations. In our case for StrictNoSign it will be this one which is essentially sha256.

For nwaku we use sha256 as defined here and the same goes for go-waku

Hereby I declare implementations are on the same page. 📜

UPD: to prevent potential problem if ChainSafe stops using sha256 for StrictNoSign we can define option for PubSub on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants