feat: use messageHash as msgIdFn #1361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weboko
commented
May 17, 2023
| * @param bytes Uint8Array | ||
| * @returns IProtoMessage | ||
| */ | ||
| export function fromBytesToProtoMessage(bytes: Uint8Array): IProtoMessage { |
There was a problem hiding this comment.
Maybe should move it to @waku/utils/message 🤔
weboko
commented
May 17, 2023
| msgIdFn: ({ topic, data }) => { | ||
| try { | ||
| const protoMessage = message.fromBytesToProtoMessage(data); | ||
| return messageHash(topic, protoMessage); |
There was a problem hiding this comment.
Problem with this implementation is that in case meta is missing hash is taken based on this concat([pubsubTopicBytes, message.payload, contentTopicBytes])
It leads to inability of a user to send a message to the a pubSub/contentTopic in case someone already published a message with the same text.
Second problem of using messageHash as msgIdFn is that it won't be consistent with hashing in nwaku/go-waku as I mentioned here
|
Closing for now. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Relay node can send or receive duplicates of messages.
Solution
Update
msgIdFnto use deterministic hashing.Notes