-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add meta
field on Waku Message and provide setter and validation interfaces
#1230
Conversation
meta
fieldmeta
field
62e8b22
to
8d7b4c3
Compare
size-limit report 📦
|
meta
fieldmeta
field on Waku Message and provide setter and validation interfaces
Cc @felicio |
Note: can be reviewed by patches (first adds encoding, second adds decoding) |
This comment was marked as resolved.
This comment was marked as resolved.
75a3506
to
b554810
Compare
b554810
to
228a0a2
Compare
228a0a2
to
2dcd16f
Compare
The validation interface Reading waku-org/pm#9 more closely, this is incorrect.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a bit complicated but good to me!
Superseded by #1238 Will wait to get more context before adding the |
Ref: #1208