Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add meta field on Waku Message and provide setter and validation interfaces #1230

Closed
wants to merge 3 commits into from

Conversation

fryorcraken
Copy link
Collaborator

Ref: #1208

@fryorcraken fryorcraken changed the title feat: enable encoding of meta field feat!: enable encoding of meta field Mar 10, 2023
@github-actions
Copy link

github-actions bot commented Mar 10, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 114.66 KB (+0.09% 🔺) 2.3 s (+0.09% 🔺) 3.5 s (+30.26% 🔺) 5.8 s
Waku default setup 366.75 KB (+0.06% 🔺) 7.4 s (+0.06% 🔺) 5.6 s (-14.65% 🔽) 13 s
ECIES encryption 27.9 KB (+0.56% 🔺) 559 ms (+0.56% 🔺) 1.2 s (-27.51% 🔽) 1.8 s
Symmetric encryption 27.91 KB (+0.56% 🔺) 559 ms (+0.56% 🔺) 1.7 s (+7.92% 🔺) 2.2 s
DNS discovery 108.05 KB (0%) 2.2 s (0%) 3.4 s (+16.68% 🔺) 5.5 s
Privacy preserving protocols 114.16 KB (+0.09% 🔺) 2.3 s (+0.09% 🔺) 2.9 s (+28.4% 🔺) 5.2 s
Light protocols 115.92 KB (+0.05% 🔺) 2.4 s (+0.05% 🔺) 2.5 s (-8.41% 🔽) 4.8 s
History retrieval protocols 115.96 KB (+0.07% 🔺) 2.4 s (+0.07% 🔺) 2.1 s (-11.64% 🔽) 4.4 s

@fryorcraken fryorcraken changed the title feat!: enable encoding of meta field feat!: add meta field on Waku Message and provide setter and validation interfaces Mar 10, 2023
@fryorcraken
Copy link
Collaborator Author

Cc @felicio

@fryorcraken fryorcraken marked this pull request as ready for review March 10, 2023 04:31
@fryorcraken
Copy link
Collaborator Author

Note: can be reviewed by patches (first adds encoding, second adds decoding)

@fryorcraken fryorcraken marked this pull request as draft March 10, 2023 05:10
@fryorcraken

This comment was marked as resolved.

@fryorcraken fryorcraken marked this pull request as ready for review March 13, 2023 03:21
@fryorcraken
Copy link
Collaborator Author

fryorcraken commented Mar 13, 2023

The validation interface isMetaValid may be premature. I assumed for some reason that the MUID would be stored in meta and hence message integrity would be checked for a given application/pubsub topic.

Reading waku-org/pm#9 more closely, this is incorrect.

meta is an application specific field. The usage is not yet defined. I believe it's likely to be a signature for Status Communities? Would be keen to have more info on that to know whether isMetaValid is useful as is, should be changed or even removed.

Cc @felicio @LNSD

Copy link
Collaborator

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a bit complicated but good to me!

@fryorcraken
Copy link
Collaborator Author

Superseded by #1238

Will wait to get more context before adding the isMetaValid helper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants