-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade libp2p and related deps #1482
Conversation
…de-libp2p-and-related
…de-libp2p-and-related
…re/upgrade-libp2p-and-related
…de-libp2p-and-related
size-limit report 📦
|
b5cbdd2
to
ae9bb8d
Compare
What is this PR and how is it not a dupe of #1471? |
Ok I understand now. I would really recommend against mixing a pure formatting PR with an actual change PR. There should have been a format PR that only does formatting and then, you can have this PR on top. Mixing both just corrupts the git history and lead to possible trouble. It also means that a PR with 135 files change was not reviewed by anyone. |
Apologies - this was not intended!! I can open a PR to manually rebase this additional commit, or at least a PR to remove these discarded formatting config changes. Sorry! |
The only way to fix this would be to push force master. I don't think it's necessary at this point of project maturity for js-waku but would be keen to avoid this in the future. |
I agree. Can't believe this commit slipped in :/ Will do a manual PR to remove the unwanted changes. |
Problems
New versions for deps like
were introduced which rely on a breaking change from libp2p to be upgraded to
0.46.3
and improvements like deprecation of certain one-off interface packages are replaced with new exports.Solutions
This PR:
0.46.3
)interface
packages fromlibp2p
and replaces them with new exportsNotes