Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade libp2p and related deps #1482

Merged
merged 19 commits into from
Aug 16, 2023

Conversation

danisharora099
Copy link
Collaborator

Problems

New versions for deps like

Solutions

This PR:

  • upgrades libp2p to latest (0.46.3)
  • upgrades chainsafe deps to latest
  • removes deprecated one-off interface packages from libp2p and replaces them with new exports

Notes

@danisharora099 danisharora099 requested a review from a team as a code owner August 16, 2023 14:19
@github-actions
Copy link

github-actions bot commented Aug 16, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 30.76 KB (+0.63% 🔺) 616 ms (+0.63% 🔺) 2.5 s (+58.31% 🔺) 3.1 s
Waku Simple Light Node 292.88 KB (+19.49% 🔺) 5.9 s (+19.49% 🔺) 9.6 s (+113.57% 🔺) 15.4 s
ECIES encryption 28.68 KB (+0.5% 🔺) 574 ms (+0.5% 🔺) 2.6 s (+184.12% 🔺) 3.2 s
Symmetric encryption 28.69 KB (+0.5% 🔺) 574 ms (+0.5% 🔺) 2.2 s (+110.61% 🔺) 2.7 s
DNS discovery 113 KB (-2.76% 🔽) 2.3 s (-2.76% 🔽) 4.1 s (+56.62% 🔺) 6.4 s
Privacy preserving protocols 125.33 KB (+0.43% 🔺) 2.6 s (+0.43% 🔺) 4.5 s (+43.43% 🔺) 7 s
Light protocols 30.49 KB (+9.83% 🔺) 610 ms (+9.83% 🔺) 2.2 s (+18.7% 🔺) 2.8 s
History retrieval protocols 29.69 KB (+9.99% 🔺) 594 ms (+9.99% 🔺) 1.6 s (-19.12% 🔽) 2.2 s
Deterministic Message Hashing 5.79 KB (+0.14% 🔺) 116 ms (+0.14% 🔺) 652 ms (+60.02% 🔺) 767 ms

@danisharora099 danisharora099 force-pushed the chore/upgrade-libp2p-and-related branch 2 times, most recently from b5cbdd2 to ae9bb8d Compare August 16, 2023 14:41
@danisharora099 danisharora099 merged commit 8771798 into master Aug 16, 2023
19 of 20 checks passed
@danisharora099 danisharora099 deleted the chore/upgrade-libp2p-and-related branch August 16, 2023 14:48
@fryorcraken
Copy link
Collaborator

What is this PR and how is it not a dupe of #1471?

@fryorcraken
Copy link
Collaborator

What is this PR and how is it not a dupe of #1471?

Ok I understand now.

I would really recommend against mixing a pure formatting PR with an actual change PR.

There should have been a format PR that only does formatting and then, you can have this PR on top.

Mixing both just corrupts the git history and lead to possible trouble.

It also means that a PR with 135 files change was not reviewed by anyone.

@danisharora099
Copy link
Collaborator Author

What is this PR and how is it not a dupe of #1471?

Ok I understand now.

I would really recommend against mixing a pure formatting PR with an actual change PR.

There should have been a format PR that only does formatting and then, you can have this PR on top.

Mixing both just corrupts the git history and lead to possible trouble.

It also means that a PR with 135 files change was not reviewed by anyone.

Apologies - this was not intended!!
#1471 was accidentally merged into chore/prettier which I rebased to remove unnecessary commits - seems like one formatting commit slipped in.

I can open a PR to manually rebase this additional commit, or at least a PR to remove these discarded formatting config changes.

Sorry!

@fryorcraken
Copy link
Collaborator

The only way to fix this would be to push force master. I don't think it's necessary at this point of project maturity for js-waku but would be keen to avoid this in the future.

@danisharora099
Copy link
Collaborator Author

The only way to fix this would be to push force master. I don't think it's necessary at this point of project maturity for js-waku but would be keen to avoid this in the future.

I agree. Can't believe this commit slipped in :/

Will do a manual PR to remove the unwanted changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants