Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Firefox and Webkit to karma #1598

Merged
merged 22 commits into from
Sep 22, 2023
Merged

feat: add Firefox and Webkit to karma #1598

merged 22 commits into from
Sep 22, 2023

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Sep 21, 2023

Problem

RIght now unit tests are run only in Chrome env.

Solution

We need to run them in other envs too.
In this PR FirefoxHeadless and WebkitHeadless are added.

Notes

@github-actions
Copy link

github-actions bot commented Sep 21, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 27.69 KB (0%) 554 ms (0%) 1.9 s (+34.55% 🔺) 2.5 s
Waku Simple Light Node 262.6 KB (0%) 5.3 s (0%) 6.5 s (+70.44% 🔺) 11.8 s
ECIES encryption 28.7 KB (0%) 574 ms (0%) 2.3 s (+38.6% 🔺) 2.8 s
Symmetric encryption 28.7 KB (0%) 575 ms (0%) 1.7 s (-8.26% 🔽) 2.3 s
DNS discovery 110.62 KB (0%) 2.3 s (0%) 3.9 s (+31.97% 🔺) 6.1 s
Privacy preserving protocols 117.38 KB (0%) 2.4 s (0%) 3.6 s (+27.51% 🔺) 5.9 s
Light protocols 25.83 KB (0%) 517 ms (0%) 1.7 s (-2.41% 🔽) 2.2 s
History retrieval protocols 24.9 KB (0%) 499 ms (0%) 1.6 s (-12.17% 🔽) 2.1 s
Deterministic Message Hashing 5.65 KB (0%) 113 ms (0%) 406 ms (-7.38% 🔽) 519 ms

@weboko weboko marked this pull request as ready for review September 22, 2023 00:15
@weboko weboko requested a review from a team as a code owner September 22, 2023 00:15
Copy link
Collaborator

@fryorcraken fryorcraken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comment in terms of avoiding dupe code

packages/core/package.json Outdated Show resolved Hide resolved
packages/dns-discovery/karma.conf.cjs Outdated Show resolved Hide resolved
Copy link
Collaborator

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar comments as discussed above with:

  • moving karma.config.js to root
  • moving dependencies shared with packages to root

should be good to merge then!

@weboko weboko merged commit d9e4bcb into master Sep 22, 2023
9 of 11 checks passed
@weboko weboko deleted the weboko/karma-firefox branch September 22, 2023 15:48
@danisharora099
Copy link
Collaborator

similar comments as discussed above with:

  • moving karma.config.js to root
  • moving dependencies shared with packages to root

should be good to merge then!

@weboko looks like these were not addressed -- are we tracking them somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants