-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Firefox and Webkit to karma #1598
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comment in terms of avoiding dupe code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar comments as discussed above with:
- moving
karma.config.js
to root - moving dependencies shared with packages to root
should be good to merge then!
@weboko looks like these were not addressed -- are we tracking them somewhere? |
Problem
RIght now unit tests are run only in Chrome env.
Solution
We need to run them in other envs too.
In this PR
FirefoxHeadless
andWebkitHeadless
are added.Notes